Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1370)

Issue 5529078: Adding new SkPathMeasure tests, defined out for now as they fail. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by Stephen Chenney
Modified:
13 years ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Adding new SkPathMeasure tests, defined out for now as they fail. Committed: http://code.google.com/p/skia/source/detail?r=3029

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -0 lines) Patch
M tests/PathMeasureTest.cpp View 1 chunk +87 lines, -0 lines 0 comments Download

Messages

Total messages: 2
reed1
lgtm -- I wonder if we can improve readability in the future with some helpers, ...
13 years ago (2012-01-12 20:02:15 UTC) #1
Stephen Chenney
13 years ago (2012-01-12 20:04:46 UTC) #2
On 2012/01/12 20:02:15, reed1 wrote:
> lgtm -- I wonder if we can improve readability in the future with some
helpers,
> e.g.
> 
> static void assert_nearly_eq(reporter, const SkPoint&, SkScalar x, SkScalar y)
{
>     ....
> }
> 
> assert_nearly_eq(reporter, tangent, 0, SK_Scalar1);
> ...
> 
> Just a thought.

I had the same thought. :-)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b