Small cleanup of unified paint settings

Small cleanup of unified paint settings

This patch moves the sculpt/paint unified fields out of ToolSettings
and into their own struct, UnifiedPaintSettings. This adds a bit of
extra readfile code and such, but its cleaner elsewhere, and avoids
cluttering ToolSettings further if more unified paint settings are
added.

This change is supposed to be backwards-compatible, but I could use
some review to make sure I'm doing that correctly. In particular:

* File subversion is bumped, and readfile.c gets a new block to move
  the data over to the new struct. I moved code from the "put here
  until next version bump" block into the same subversion check.

* Added RNA for the new struct, and added get/set functions for the
  old unified flag properties so that they still work. Also marked the
  old unified flag properties' UI text/description with
  "Deprecated"... not sure if this is correct procedure though.

As already noted in brush.c by Campbell, many of the brush
getter/setter functions are doing an ugly (and incorrect) thing with
looping through scenes, rather than directly passing a scene in -- I
intend to address that next in a separate patch, wanted to get this
cleanup out of the way first.

[brechtvl, 2012-01-12 15:00:57]

Looks ok, one comment.

http://codereview.appspot.com/5529077/diff/1/source/blender/makesrna/intern/r...
File source/blender/makesrna/intern/rna_scene.c (right):

http://codereview.appspot.com/5529077/diff/1/source/blender/makesrna/intern/r...
source/blender/makesrna/intern/rna_scene.c:1656: RNA_def_property_ui_text(prop,
"Sculpt/Paint Use Unified Radius (Deprecated)",
The manual get/set functions aren't really needed, passing
"unified_paint_settings.flag" to RNA should work.

However I don't think deprecated RNA properties need to be kept around this way,
especially ones that are unlikely to be used much in scripts, can just remove
them.

[nicholasbishop, 2012-01-12 17:23:37]

Thanks, committed sans deprecated RNA props.

On 2012/01/12 15:00:57, brechtvl wrote:
> Looks ok, one comment.
> 
>
http://codereview.appspot.com/5529077/diff/1/source/blender/makesrna/intern/r...
> File source/blender/makesrna/intern/rna_scene.c (right):
> 
>
http://codereview.appspot.com/5529077/diff/1/source/blender/makesrna/intern/r...
> source/blender/makesrna/intern/rna_scene.c:1656:
RNA_def_property_ui_text(prop,
> "Sculpt/Paint Use Unified Radius (Deprecated)",
> The manual get/set functions aren't really needed, passing
> "unified_paint_settings.flag" to RNA should work.
> 
> However I don't think deprecated RNA properties need to be kept around this
way,
> especially ones that are unlikely to be used much in scripts, can just remove
> them.