Issue 5527047: Prevents Beam vs Flag collisions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5527047: Prevents Beam vs Flag collisions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by MikeSol

Modified:
12 years, 3 months ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Patch Set 2 : Gets rid of extraneous lily-guile.cc code. #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
	A	input/regression/beam-collision-flag.ly	View		1 chunk	+11 lines, -0 lines	0 comments	Download
	M	lily/beam-collision-engraver.cc	View		3 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lemzwerg

LGTM. Will test soon. http://codereview.appspot.com/5527047/diff/1/lily/lily-guile.cc File lily/lily-guile.cc (left): http://codereview.appspot.com/5527047/diff/1/lily/lily-guile.cc#oldcode573 lily/lily-guile.cc:573: int i = scm_to_int (k); ...

12 years, 3 months ago (2012-01-07 15:18:07 UTC) #1

MikeSol

12 years, 3 months ago (2012-01-07 15:19:58 UTC) #2

On 2012/01/07 15:18:07, lemzwerg wrote:
> LGTM.  Will test soon.
> 
> http://codereview.appspot.com/5527047/diff/1/lily/lily-guile.cc
> File lily/lily-guile.cc (left):
> 
> http://codereview.appspot.com/5527047/diff/1/lily/lily-guile.cc#oldcode573
> lily/lily-guile.cc:573: int i = scm_to_int (k);
> Please apply this cosmetic patch directly to the repository; I think it
doesn't
> belong to the rest of the patch set.

Sorry ... I have no clue why this is here.
Will get rid of it.

Expand All Messages | Collapse All Messages