Issue 5524043: Fix a typo.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5524043: Fix a typo. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by Peng

Modified:
12 years, 3 months ago

Reviewers:
Yusuke Sato, Daiki Ueno

Base URL:
git@github.com:ibus/ibus-m17n.git@master

Visibility:
Public.

More Reviews

Description

Fix a typo. BUG=None TEST=Manually

Patch Set 1 #

Patch Set 2 : update #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/engine.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Daiki Ueno

lgtm. btw glib seems to recommend "U+%04"G_GINT32_FORMAT"X" to print unichar in U+ notation: http://developer.gnome.org/glib/unstable/glib-Unicode-Manipulation.html#gunichar

12 years, 3 months ago (2012-01-06 01:13:28 UTC) #2

Yusuke Sato

lgtm, +1 to G_GINT32_FORMAT. On 2012/01/06 01:13:28, Daiki Ueno wrote: > lgtm. btw glib seems ...

12 years, 3 months ago (2012-01-06 09:39:32 UTC) #3

Peng

12 years, 3 months ago (2012-01-06 15:20:22 UTC) #4

fixed. thanks
On 2012/01/06 09:39:32, Yusuke Sato wrote:
> lgtm, +1 to G_GINT32_FORMAT.
> 
> On 2012/01/06 01:13:28, Daiki Ueno wrote:
> > lgtm.  btw glib seems to recommend "U+%04"G_GINT32_FORMAT"X" to print
unichar
> in
> > U+ notation:
> > 
> >
>
http://developer.gnome.org/glib/unstable/glib-Unicode-Manipulation.html#gunichar

Expand All Messages | Collapse All Messages