Add --add-new-files option to download-baselines.py script

Add --add-new-files option to download-baselines.py script

This will allow the user to determine whether the script downloads just
updates for baselines that are already checked in, or all available baselines.

BUG=436
addresses http://code.google.com/p/skia/issues/detail?id=436 ('add "update" flag to download-baselines script')
Committed: http://code.google.com/p/skia/source/detail?r=2993

[bungeman, 2012-01-06 22:54:02]

http://codereview.appspot.com/5523050/diff/1/tools/download-baselines.py
File tools/download-baselines.py (right):

http://codereview.appspot.com/5523050/diff/1/tools/download-baselines.py#newc...
tools/download-baselines.py:162: DownloadMatchingFiles(results_url, IMAGE_REGEX,
baseline_subdir)
This is most expedient for now, but it just seems so wasteful to download
everything only to delete a bunch. Maybe in the future a flag to
DownloadMatchingFiles to only download if there already exists a file with that
name. May not even be worth it though.

http://codereview.appspot.com/5523050/diff/1/tools/svn.py
File tools/svn.py (right):

http://codereview.appspot.com/5523050/diff/1/tools/svn.py#newcode50
tools/svn.py:50: new_regex = re.compile(' +(.+)')
Only items without modifications? This doesn't seem to include modified files.

Just to be pedantic about regexes, the svn spec says that this status call
returns something which matches

^[ ADMRCXI?!~][ MC][ L][ +][ S][ KOBT][ C][ ](.+)

with MULTILINE mode enabled. Perhaps you something like

^[ AM][ MC][ L][ +][ S][ KOBT][ C][ ](.+)

or

^[ AM]??????[ ](.+)

Also, something similar for the above regex in GetNewFiles.

[epoger, 2012-01-09 21:30:58]

Thanks for the suggestions!  Should be better now...

http://codereview.appspot.com/5523050/diff/1/tools/download-baselines.py
File tools/download-baselines.py (right):

http://codereview.appspot.com/5523050/diff/1/tools/download-baselines.py#newc...
tools/download-baselines.py:162: DownloadMatchingFiles(results_url, IMAGE_REGEX,
baseline_subdir)
On 2012/01/06 22:54:02, bungeman wrote:
> This is most expedient for now, but it just seems so wasteful to download
> everything only to delete a bunch. Maybe in the future a flag to
> DownloadMatchingFiles to only download if there already exists a file with
that
> name. May not even be worth it though.

Good idea.  I had initially decided not to bother, but it's not that hard to do
and indeed it is silly to download a bunch and then delete them.

http://codereview.appspot.com/5523050/diff/1/tools/svn.py
File tools/svn.py (right):

http://codereview.appspot.com/5523050/diff/1/tools/svn.py#newcode50
tools/svn.py:50: new_regex = re.compile(' +(.+)')
On 2012/01/06 22:54:02, bungeman wrote:
> Only items without modifications? This doesn't seem to include modified files.
> 
> Just to be pedantic about regexes, the svn spec says that this status call
> returns something which matches
> 
> ^[ ADMRCXI?!~][ MC][ L][ +][ S][ KOBT][ C][ ](.+)
> 
> with MULTILINE mode enabled. Perhaps you something like
> 
> ^[ AM][ MC][ L][ +][ S][ KOBT][ C][ ](.+)
> 
> or
> 
> ^[ AM]??????[ ](.+)
> 
> Also, something similar for the above regex in GetNewFiles.

Right you are, thanks for catching this.  Fixed.

[bungeman, 2012-01-09 21:40:57]

LGTM