Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2181)

Issue 5523048: Move Gradient inner loops into procs (except for perspective) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by TomH
Modified:
12 years, 10 months ago
Reviewers:
reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Mostly a refactoring, but a couple of substantive changes: - replace some hardcoded 8s with appropriate symbolic constants (kCache32Shift) - 16b TOGGLE_MASK was using the 32b cache size (old line 1010); switched to the 16b cache size (new line 142), which happens to be the same number at the moment. We pass two float args to radial procs whether or not we're using float square roots; I'm open the alternative of changing the signature of the proc depending on that #define, but it'll be uglier.

Patch Set 1 #

Patch Set 2 : Upload buggy patch for diff tools #

Patch Set 3 : Working code #

Patch Set 4 : Style fix & missing semicolon #

Unified diffs Side-by-side diffs Delta from patch set Stats (+455 lines, -270 lines) Patch
M src/effects/SkGradientShader.cpp View 1 2 3 28 chunks +455 lines, -270 lines 0 comments Download

Messages

Total messages: 4
TomH
12 years, 10 months ago (2012-01-06 18:42:37 UTC) #1
TomH
This version passes GMs, and is currently being subjected to LayoutTests on ToT.
12 years, 10 months ago (2012-01-06 20:53:03 UTC) #2
TomH
Passes LayoutTests with no new breakage. Benchmarking is mostly the same, some improvement for mirrored ...
12 years, 10 months ago (2012-01-06 21:49:41 UTC) #3
TomH
12 years, 10 months ago (2012-01-09 13:46:01 UTC) #4
Committed in r2988 with verbal LGTM from reed@.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b