Issue 5522050: Correct GPU glyph positioning.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5522050: Correct GPU glyph positioning. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by bungeman

Modified:
12 years, 8 months ago

Reviewers:
bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -19 lines)			Patch
	M	src/gpu/SkGpuDevice.cpp	View		1 chunk	+6 lines, -19 lines	0 comments	Download

Total messages: 3

bungeman

SkDraw has already figured out where it wants to draw the glyph, so just use ...

12 years, 8 months ago (2012-01-09 15:53:27 UTC) #1

bsalomon

On 2012/01/09 15:53:27, bungeman wrote: > SkDraw has already figured out where it wants to ...

12 years, 8 months ago (2012-01-09 16:12:32 UTC) #2

bungeman

12 years, 8 months ago (2012-01-11 16:29:08 UTC) #3

Committed revision 3010.

After much testing, I have yet to see any layout failures as a result of this
change.