Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(231)

Issue 5520051: Fix a bug in long variable name mapping. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by zmo
Modified:
13 years, 7 months ago
Reviewers:
kbr1, kbr
CC:
angleproject-review_googlegroups.com, gmanchromium
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix a bug in long variable name mapping. Originally we only match varying variables in vertex/fragment shaders. However, we should also match uniform names. For example, if a uniform variable name is used in both vertex and fragment shader, and after mapping the names are different, then the name mapping table is no longer 1:1. BUG=106638 (crbug) TEST=http://seanseefried.com/chrome-bug/simple-broken.html shows a magenta square Committed: http://code.google.com/p/angleproject/source/detail?r=939

Patch Set 1 : '' #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/common/version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/MapLongVariableNames.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4
zmo
Please review. Tested locally with the test case provided by bug reporter. Ken, should we ...
13 years, 7 months ago (2012-01-06 01:20:51 UTC) #1
kbr1
On 2012/01/06 01:20:51, zmo wrote: > Please review. Tested locally with the test case provided ...
13 years, 7 months ago (2012-01-06 02:11:20 UTC) #2
zmo
On 2012/01/06 02:11:20, kbr1 wrote: > On 2012/01/06 01:20:51, zmo wrote: > > Please review. ...
13 years, 7 months ago (2012-01-06 02:15:21 UTC) #3
kbr1
13 years, 7 months ago (2012-01-06 02:16:22 UTC) #4
On 2012/01/06 02:15:21, zmo wrote:
> Tested, no more failures than without this CL.

LGTM then.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b