Issue 5520046: Do unpremult/premult steps in GPU color matrix

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5520046: Do unpremult/premult steps in GPU color matrix (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by Stephen White

Modified:
12 years, 11 months ago

Reviewers:
bsalomon

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

When applying a color matrix, unpremultiply the source, and premultiply the result. If the input color is missing, set to all-zeros or all-ones as appropriate. Add an alpha test case to the colormatrix GM.

Patch Set 1 #

Patch Set 2 : Fix GLPrograms test by refactored all-ones/all-zeros prep code #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -12 lines)			Patch
gm/colormatrix.cpp	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
src/gpu/GrGLProgram.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
src/gpu/GrGLProgram.cpp	View	1	4 chunks	+18 lines, -12 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Stephen White

On 2012/01/05 16:57:28, bsalomon wrote: > On 2012/01/05 16:39:01, Stephen White wrote: > > LGTM ...

12 years, 11 months ago (2012-01-05 16:59:57 UTC) #3

Stephen White

Fix GLPrograms test by refactored all-ones/all-zeros prep code

12 years, 11 months ago (2012-01-05 17:50:34 UTC) #4

bsalomon

On 2012/01/05 17:50:34, Stephen White wrote: > Fix GLPrograms test by refactored all-ones/all-zeros prep code ...

12 years, 11 months ago (2012-01-05 18:15:31 UTC) #5

Stephen White

12 years, 11 months ago (2012-01-05 18:30:23 UTC) #6

On 2012/01/05 18:15:31, bsalomon wrote:
> On 2012/01/05 17:50:34, Stephen White wrote:
> > Fix GLPrograms test by refactored all-ones/all-zeros prep code
> 
> LGTM

Landed as r2974.  Closing.

Expand All Messages | Collapse All Messages