Issue 5519045: Mac generateFontMetrics not converting to scalar.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5519045: Mac generateFontMetrics not converting to scalar. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by bungeman

Modified:
12 years, 8 months ago

Reviewers:
caryclark1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Patch Set 2 : Use existing CG to scalar converter. #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -22 lines)			Patch
	M	src/ports/SkFontHost_mac_coretext.cpp	View	1	1 chunk	+10 lines, -22 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

caryclark1

http://codereview.appspot.com/5519045/diff/1/src/ports/SkFontHost_mac_coretext.cpp File src/ports/SkFontHost_mac_coretext.cpp (right): http://codereview.appspot.com/5519045/diff/1/src/ports/SkFontHost_mac_coretext.cpp#newcode32 src/ports/SkFontHost_mac_coretext.cpp:32: #ifdef CGFLOAT_IS_DOUBLE Remove this and use ScalarToCG instead http://codereview.appspot.com/5519045/diff/1/src/ports/SkFontHost_mac_coretext.cpp#newcode1302 ...

12 years, 8 months ago (2012-01-05 20:59:39 UTC) #2

bungeman

http://codereview.appspot.com/5519045/diff/1/src/ports/SkFontHost_mac_coretext.cpp File src/ports/SkFontHost_mac_coretext.cpp (right): http://codereview.appspot.com/5519045/diff/1/src/ports/SkFontHost_mac_coretext.cpp#newcode32 src/ports/SkFontHost_mac_coretext.cpp:32: #ifdef CGFLOAT_IS_DOUBLE On 2012/01/05 20:59:39, caryclark1 wrote: > Remove ...

12 years, 8 months ago (2012-01-05 21:10:54 UTC) #3

Committed revision 2979.

Expand All Messages | Collapse All Messages