Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(789)

Issue 551830043: Fix warnings related to po (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by hahnjo
Modified:
3 years, 11 months ago
Reviewers:
dak, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix warnings related to po Individual commits: 1) Build lilypond-doc in Documentation/po This avoids warning messages from langdefs.py which tries to load that locale domain and is also imported during a 'normal' build while producing the .texi and .info files in Documentation/. 2) Inline po-* targets into po/ Documentation/po/ has a custom po-update. Also drop po-changes, it's only spamming the output when running po-update.

Patch Set 1 #

Total comments: 2

Patch Set 2 : drop po-changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -57 lines) Patch
M Documentation/po/GNUmakefile View 3 chunks +3 lines, -8 lines 0 comments Download
M GNUmakefile.in View 2 chunks +1 line, -9 lines 0 comments Download
M make/lilypond-vars.make View 1 chunk +1 line, -1 line 0 comments Download
M po/GNUmakefile View 1 2 chunks +11 lines, -5 lines 0 comments Download
M stepmake/stepmake/generic-targets.make View 1 chunk +4 lines, -2 lines 0 comments Download
M stepmake/stepmake/podir-targets.make View 1 chunk +0 lines, -27 lines 0 comments Download
M stepmake/stepmake/podir-vars.make View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 5
lemzwerg
LGTM, thanks a lot! https://codereview.appspot.com/551830043/diff/573740043/po/GNUmakefile File po/GNUmakefile (right): https://codereview.appspot.com/551830043/diff/573740043/po/GNUmakefile#newcode14 po/GNUmakefile:14: sed-makestuff = -e 's/[a-zA-Z_/]*make\[[0-9]*\].*//' shouldn't ...
3 years, 11 months ago (2020-04-24 18:25:33 UTC) #1
hahnjo
On 2020/04/24 18:25:33, lemzwerg wrote: > LGTM, thanks a lot! > > https://codereview.appspot.com/551830043/diff/573740043/po/GNUmakefile > File ...
3 years, 11 months ago (2020-04-24 20:14:36 UTC) #2
hahnjo
drop po-changes
3 years, 11 months ago (2020-04-25 08:31:19 UTC) #3
hahnjo
On 2020/04/24 20:14:36, hahnjo wrote: > On 2020/04/24 18:25:33, lemzwerg wrote: > > LGTM, thanks ...
3 years, 11 months ago (2020-04-25 08:36:02 UTC) #4
dak
3 years, 11 months ago (2020-04-25 09:39:08 UTC) #5
On 2020/04/25 08:36:02, hahnjo wrote:
> On 2020/04/24 20:14:36, hahnjo wrote:
> > On 2020/04/24 18:25:33, lemzwerg wrote:
> > > LGTM, thanks a lot!
> > > 
> > > https://codereview.appspot.com/551830043/diff/573740043/po/GNUmakefile
> > > File po/GNUmakefile (right):
> > > 
> > >
> >
>
https://codereview.appspot.com/551830043/diff/573740043/po/GNUmakefile#newcode14
> > > po/GNUmakefile:14: sed-makestuff = -e 's/[a-zA-Z_/]*make\[[0-9]*\].*//'
> > > shouldn't this be rather '[0-9]\+'?
> > > 
> > >
> >
>
https://codereview.appspot.com/551830043/diff/573740043/po/GNUmakefile#newcode15
> > > po/GNUmakefile:15: sed-edstuff = -e 's/[ \.,adic0-9]*//' -e 's/---//' |
sort
> > -u
> > > I think that within '[...]' you don't have to escape '.'.
> > > 
> > > And again I would use '\+' instead of '*'.
> > 
> > To be honest, I have no clue what all of this is doing: I copied it from
> > stepmake/stepmake/podir-targets.make.
> 
> After looking through the code once more, this sed magic is only used for
> po-changes. This spams the output when running po-update which is pointless
IMO
> because the one updating lilypond.pot is not going to update all languages at
> the same time. Thus, I'm dropping it in the updated patch set.

At any rate, I don't think the backslash is intended to escape the period rather
than just be literally enclosed in the character list.  Some people tend to do
this in the form of the redundant \\ in order to not confuse human readers and
almost but not quite syntax-aware editors, but with regard to the actual
interpretation, it is not doing anything.  Not even escaping the backslash
itself: something like [A-\\-~] is still two ranges rather than a single range
followed by two isolated characters, the interpretation that would result from
"proper" backslash escaping.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b