Issue 551820043: Don't use C++ operator synonym "not"

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 551820043: Don't use C++ operator synonym "not"

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years ago by dak

Modified:
4 years ago

Reviewers:
Dan Eble, lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Don't use C++ operator synonym "not" We don't use operator synonyms elsewhere, and they are pretty uncommon.

Patch Set 1 #

Total comments: 1

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	lily/stencil-integral.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Dan Eble

4 years ago (2020-04-22 20:59:26 UTC) #2

https://codereview.appspot.com/551820043/diff/563910043/lily/stencil-integral.cc
File lily/stencil-integral.cc (left):

https://codereview.appspot.com/551820043/diff/563910043/lily/stencil-integral...
lily/stencil-integral.cc:854: if (not scm_is_pair (expr))
LGTM.  I forgot that keyword existed!  :D

Expand All Messages | Collapse All Messages