Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(476)

Issue 551580044: Fix Windows resource to enable manifest

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by trueroad
Modified:
4 years ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 5828: Fix Windows resource to enable manifest A manifest file `lilypond.manifest` is specified in resource file `lilypond.rc` for the Windows executables. To specify the manifest, the definitions `CREATEPROCESS_MANIFEST_RESOURCE_ID` and `RT_MANIFEST` are required in the resource file. However, the manifest was not activated because the resource file did not include `winuser.h` that contained the required definitions. Threfore, Unicode filenames could not be used because the manifest was not activated. This commit adds the include file `winuser.h` to the resoruce file and activates the manifest. This allows LilyPond for Windows to use Unicode filenames.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M lily/lilypond.rc.in View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8
lemzwerg
LGTM
4 years ago (2020-03-07 09:57:39 UTC) #1
Be-3
LGTM (in combination with issue 5833). Many users of Windows will be quite happy about ...
4 years ago (2020-03-08 11:27:52 UTC) #2
dak
On 2020/03/08 11:27:52, Be-3 wrote: > LGTM (in combination with issue 5833). Many users of ...
4 years ago (2020-03-08 11:38:29 UTC) #3
Be-3
On 2020/03/08 11:38:29, dak wrote: > We don't really document bug fixes as a rule ...
4 years ago (2020-03-08 12:11:43 UTC) #4
thomasmorley651
On 2020/03/08 12:11:43, Be-3 wrote: > On 2020/03/08 11:38:29, dak wrote: > > We don't ...
4 years ago (2020-03-08 12:16:55 UTC) #5
dak
On 2020/03/08 12:16:55, thomasmorley651 wrote: > On 2020/03/08 12:11:43, Be-3 wrote: > > On 2020/03/08 ...
4 years ago (2020-03-08 12:48:51 UTC) #6
trueroad
I've added changes.tely entry in Issue 5833. This Issue 5828 became "push", but I would ...
4 years ago (2020-03-11 12:08:49 UTC) #7
trueroad
4 years ago (2020-03-15 13:01:29 UTC) #8
Issue 5833 has become "push".

So I've pushed this Issue 5828 to staging.

commit 3b9fd3f24b992e9bb5effb76cb2abc70aa9551c9
Issue 5828: Fix Windows resource to enable manifest
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b