Issue 5515051: Change resumable upload chunksize to 150K

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5515051: Change resumable upload chunksize to 150K (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by jcgregorio_google

Modified:
13 years, 6 months ago

Reviewers:
aiuto

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	apiclient/http.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

aiuto

lgtm On Fri, Jan 6, 2012 at 2:48 PM, <jcgregorio@google.com> wrote: > Reviewers: aiuto, > ...

13 years, 6 months ago (2012-01-06 20:12:27 UTC) #2

jcgregorio_google

13 years, 6 months ago (2012-01-06 20:56:38 UTC) #3

Committed at
http://code.google.com/p/google-api-python-client/source/detail?r=a2093b1d92b...

On 2012/01/06 20:12:27, aiuto wrote:
> lgtm
> 
> On Fri, Jan 6, 2012 at 2:48 PM, <mailto:jcgregorio@google.com> wrote:
> 
> > Reviewers: aiuto,
> >
> >
> >
> > Please review this at
>
http://codereview.appspot.com/**5515051/%3Chttp://codereview.appspot.com/5515...>
> >
> > Affected files:
> >  M apiclient/http.py
> >
> >
> > Index: apiclient/http.py
> > ==============================**==============================**=======
> > --- a/apiclient/http.py
> > +++ b/apiclient/http.py
> > @@ -151,7 +151,7 @@
> >         media_body=media).execute()
> >   """
> >
> > -  def __init__(self, filename, mimetype=None, chunksize=10000,
> > resumable=False):
> > +  def __init__(self, filename, mimetype=None, chunksize=150000,
> > resumable=False):
> >     """Constructor.
> >
> >     Args:
> >
> >
> >

Expand All Messages | Collapse All Messages