Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(832)

Issue 5515051: Change resumable upload chunksize to 150K (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by jcgregorio_google
Modified:
12 years, 8 months ago
Reviewers:
aiuto
CC:
google-api-python-client_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M apiclient/http.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
jcgregorio_google
12 years, 8 months ago (2012-01-06 19:48:21 UTC) #1
aiuto
lgtm On Fri, Jan 6, 2012 at 2:48 PM, <jcgregorio@google.com> wrote: > Reviewers: aiuto, > ...
12 years, 8 months ago (2012-01-06 20:12:27 UTC) #2
jcgregorio_google
12 years, 8 months ago (2012-01-06 20:56:38 UTC) #3
Committed at
http://code.google.com/p/google-api-python-client/source/detail?r=a2093b1d92b...

On 2012/01/06 20:12:27, aiuto wrote:
> lgtm
> 
> On Fri, Jan 6, 2012 at 2:48 PM, <mailto:jcgregorio@google.com> wrote:
> 
> > Reviewers: aiuto,
> >
> >
> >
> > Please review this at
>
http://codereview.appspot.com/**5515051/%3Chttp://codereview.appspot.com/5515...>
> >
> > Affected files:
> >  M apiclient/http.py
> >
> >
> > Index: apiclient/http.py
> > ==============================**==============================**=======
> > --- a/apiclient/http.py
> > +++ b/apiclient/http.py
> > @@ -151,7 +151,7 @@
> >         media_body=media).execute()
> >   """
> >
> > -  def __init__(self, filename, mimetype=None, chunksize=10000,
> > resumable=False):
> > +  def __init__(self, filename, mimetype=None, chunksize=150000,
> > resumable=False):
> >     """Constructor.
> >
> >     Args:
> >
> >
> >
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b