Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(293)

Issue 551430044: Some cleanups for Python code (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 2 months ago by hahnjo
Modified:
4 years, 2 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Some cleanups for Python code Individual changes: 1) Update documentation for Python 3 2) Use gettext.install() for translations This conveniently installs _() into Python's builtins namespace. 3) Drop require_python_version() The implemented 'help' for the user by opening the browser does not work on Linux anyway. 4) Suggested changes for a newer version of Python Some comments already referred to simpler code, let's do it.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -80 lines) Patch
M Documentation/contributor/doc-work.itexi View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/cs/usage/setup.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/de/usage/setup.itely View 1 chunk +1 line, -1 line 0 comments Download
M python/book_base.py View 1 chunk +0 lines, -1 line 0 comments Download
M python/book_latex.py View 1 chunk +0 lines, -1 line 0 comments Download
M python/book_snippets.py View 2 chunks +2 lines, -8 lines 0 comments Download
M python/book_texinfo.py View 1 chunk +0 lines, -1 line 0 comments Download
M python/convertrules.py View 1 chunk +0 lines, -2 lines 0 comments Download
M python/lilylib.py View 3 chunks +3 lines, -31 lines 0 comments Download
M python/musicexp.py View 1 chunk +0 lines, -2 lines 0 comments Download
M python/musicxml.py View 1 chunk +0 lines, -2 lines 0 comments Download
M python/musicxml2ly_conversion.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/abc2ly.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/build/create-weblinks-itexi.py View 1 chunk +1 line, -8 lines 0 comments Download
M scripts/build/mass-link.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/build/output-distance.py View 1 chunk +1 line, -4 lines 0 comments Download
M scripts/convert-ly.py View 3 chunks +3 lines, -8 lines 0 comments Download
M scripts/etf2ly.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/lilypond-book.py View 2 chunks +0 lines, -3 lines 0 comments Download
M scripts/midi2ly.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/musicxml2ly.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1
lemzwerg
4 years, 2 months ago (2020-02-02 13:48:27 UTC) #1
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b