Issue 5514043: Allow 0 as a valid text size in SkPaint.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5514043: Allow 0 as a valid text size in SkPaint. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by DerekS

Modified:
12 years, 10 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Allow 0 as a valid text size in SkPaint. Committed: http://code.google.com/p/skia/source/detail?r=2961

Patch Set 1 #

Total comments: 1

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	src/core/SkPaint.cpp	View		2 chunks	+8 lines, -1 line	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

reed1

12 years, 10 months ago (2012-01-04 17:54:18 UTC) #2

lgtm

http://codereview.appspot.com/5514043/diff/1/src/core/SkPaint.cpp
File src/core/SkPaint.cpp (right):

http://codereview.appspot.com/5514043/diff/1/src/core/SkPaint.cpp#newcode982
src/core/SkPaint.cpp:982: 
nit: we should try to not put an lvalue on the left of the compare.

if (0 == fTextSize) ...

Expand All Messages | Collapse All Messages