Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2182)

Issue 551390046: Issue 5689: Refactor enforcement of a single Score context (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by Dan Eble
Modified:
4 years, 2 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5689/ Context::find_create_context () and Context::create_unique_context () no longer require special cases to avoid ascending to the Global context or to create a Score themselves. Instead, the method that they each call to create any new context, Context::create_hierarchy (), avoids creating multiple Scores. This is still hard-coded in C++ to happen for Score only, but it would be straightforward to add a context attribute that could be used in ly code like \accepts and \defaultchild. After trying a number of verbose names for this attribute of the Score context, I convinced myself that "Score adopts X" does not stretch the genealogy metaphor too far. If you don't like the term, please suggest another.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -38 lines) Patch
M lily/context.cc View 5 chunks +40 lines, -38 lines 0 comments Download
M lily/context-def.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M lily/include/context.hh View 2 chunks +4 lines, -0 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b