Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(671)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
5511044
: Reverts public interface for simple spacer. (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by
MikeSol
Modified:
13 years, 2 months ago
Reviewers:
carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.
Description
Reverts public interface for simple spacer.
Patch Set 1
#
Patch Set 2 : Rebase against current master.
#
Created:
13 years, 3 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+188 lines, -263 lines
)
Patch
D
lily/column-description.cc
View
1
1 chunk
+0 lines, -72 lines
0 comments
Download
M
lily/constrained-breaking.cc
View
1
2 chunks
+5 lines, -14 lines
0 comments
Download
D
lily/include/column-description.hh
View
1
1 chunk
+0 lines, -67 lines
0 comments
Download
M
lily/include/item.hh
View
1
1 chunk
+1 line, -1 line
0 comments
Download
M
lily/include/paper-column.hh
View
1
1 chunk
+0 lines, -1 line
0 comments
Download
M
lily/include/simple-spacer.hh
View
1
3 chunks
+6 lines, -4 lines
0 comments
Download
M
lily/include/system.hh
View
1
2 chunks
+0 lines, -3 lines
0 comments
Download
M
lily/item.cc
View
1
1 chunk
+0 lines, -9 lines
0 comments
Download
M
lily/paper-column.cc
View
1
1 chunk
+0 lines, -6 lines
0 comments
Download
M
lily/simple-spacer.cc
View
1
6 chunks
+176 lines, -9 lines
0 comments
Download
M
lily/system.cc
View
1
2 chunks
+0 lines, -77 lines
0 comments
Download
Messages
Total messages: 1
Expand All Messages
|
Collapse All Messages
Carl
LGTM. Carl
13 years, 3 months ago (2012-01-04 16:16:20 UTC)
#1
LGTM. Carl
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 5511044: Reverts public interface for simple spacer. (Closed)
Created 13 years, 3 months ago by MikeSol
Modified 13 years, 2 months ago
Reviewers: carl.d.sorensen_gmail.com
Base URL:
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b