Issue 5509049: Make font scaler gm work correctly in fixed point.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5509049: Make font scaler gm work correctly in fixed point. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by bungeman

Modified:
12 years, 8 months ago

Reviewers:
epoger

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : Don't change the image by actually using the fonts. #

Total comments: 4

Patch Set 3 : Line lengths and dead code removal. #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -42 lines)			Patch
	M	gm/fontscaler.cpp	View	1 2	6 chunks	+6 lines, -42 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bungeman

The current incorrect fixed point output isn't in the repository yet, so no rebaseline needed.

12 years, 8 months ago (2012-01-04 22:45:29 UTC) #1

epoger

Thanks for the fix... a couple questions, though... http://codereview.appspot.com/5509049/diff/3/gm/fontscaler.cpp File gm/fontscaler.cpp (right): http://codereview.appspot.com/5509049/diff/3/gm/fontscaler.cpp#newcode101 gm/fontscaler.cpp:101: r.set(x-SkIntToScalar(3), ...

12 years, 8 months ago (2012-01-04 23:46:46 UTC) #2

bungeman

http://codereview.appspot.com/5509049/diff/3/gm/fontscaler.cpp File gm/fontscaler.cpp (right): http://codereview.appspot.com/5509049/diff/3/gm/fontscaler.cpp#newcode101 gm/fontscaler.cpp:101: r.set(x-SkIntToScalar(3), SkIntToScalar(15), x-SkIntToScalar(1), SkIntToScalar(280)); On 2012/01/04 23:46:47, epoger wrote: ...

12 years, 8 months ago (2012-01-05 15:07:28 UTC) #3

Committed revision 2973.

Expand All Messages | Collapse All Messages