Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5728)

Issue 5509048: Fix SK_RESTRICT errors in SkColorMatrixFilter (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by Stephen White
Modified:
12 years, 10 months ago
Reviewers:
TomH, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix incorrect use of the SK_RESTRICT macro in SkColorMatrixFilter, and re-enable the colormatrix GM test. MSC was generating incorrect code, assuming that the "result" variable inside the processing functions and the "result" variable in filterSpan*() do not alias, which they do. I removed the use of SK_RESTRICT from the latter. I've also removed it from asColorMatrix() and setup(). Although I didn't notice any pointer aliasing in those functions today, performance is not critical and someone might inadvertently introduce aliasing in the future.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
gyp/gmslides.gypi View 1 chunk +1 line, -3 lines 0 comments Download
src/effects/SkColorMatrixFilter.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5
Stephen White
12 years, 10 months ago (2012-01-04 21:39:00 UTC) #1
TomH
Oh, proc is writing state->fResult? :( LGTM
12 years, 10 months ago (2012-01-04 21:46:36 UTC) #2
reed1
LGTM, except that I would like to keep its use in asColorMatrix. In fact, I ...
12 years, 10 months ago (2012-01-04 22:12:53 UTC) #3
TomH
Close me!
12 years, 10 months ago (2012-01-05 18:29:53 UTC) #4
Stephen White
12 years, 10 months ago (2012-01-05 18:38:11 UTC) #5
On 2012/01/05 18:29:53, TomH wrote:
> Close me!

Landed as r2963; closing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b