Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(444)

Issue 550780043: Doc: NR - 2.10 World Music Turkish Classical additions

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by lilypond-pkx
Modified:
4 years, 9 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: NR - 2.10 World Music Turkish Classical additions Additions to Turkish Classical Music From suggestions made by Adam Good also references to Adam's recent Turkish Makam additions. Removed @lilypond example and made it a snippet. Formatted changed sections so they follow more closely to the CG Guidelines. Removed the table listing some of the modes and referenced the Turkish Makam ly file instead as it has significantly more additions.

Patch Set 1 #

Total comments: 20

Patch Set 2 : with Werner's corrections. Thanks. #

Total comments: 2

Patch Set 3 : Werner's nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -123 lines) Patch
M Documentation/notation/world.itely View 1 2 13 chunks +133 lines, -123 lines 0 comments Download
A Documentation/snippets/new/turkish-makam-example.ly View 1 2 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 6
lemzwerg
LGTM, but some comments. Thanks for working on this! https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely File Documentation/notation/world.itely (right): https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode74 Documentation/notation/world.itely:74: ...
4 years, 10 months ago (2019-05-31 07:05:12 UTC) #1
lilypond-pkx
https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely File Documentation/notation/world.itely (right): https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode74 Documentation/notation/world.itely:74: Western staff notes are still used, but with special ...
4 years, 9 months ago (2019-06-04 20:09:44 UTC) #2
lilypond-pkx
with Werner's corrections. Thanks.
4 years, 9 months ago (2019-06-04 20:10:56 UTC) #3
lemzwerg
LGTM, thanks, with one minor remaining nit. https://codereview.appspot.com/550780043/diff/570700043/Documentation/notation/world.itely File Documentation/notation/world.itely (right): https://codereview.appspot.com/550780043/diff/570700043/Documentation/notation/world.itely#newcode562 Documentation/notation/world.itely:562: The correct ...
4 years, 9 months ago (2019-06-05 10:52:09 UTC) #4
lilypond-pkx
https://codereview.appspot.com/550780043/diff/570700043/Documentation/notation/world.itely File Documentation/notation/world.itely (right): https://codereview.appspot.com/550780043/diff/570700043/Documentation/notation/world.itely#newcode562 Documentation/notation/world.itely:562: The correct accidentals koma flat (@var{b1}), and koma sharp ...
4 years, 9 months ago (2019-06-07 06:21:03 UTC) #5
lilypond-pkx
4 years, 9 months ago (2019-06-07 06:21:30 UTC) #6
Werner's nit.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b