Issue 550650043: Documentation: elaborate NR `custom percussion’ section

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 550650043: Documentation: elaborate NR `custom percussion’ section (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 12 months ago by Valentin Villenave

Modified:
4 years, 11 months ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Documentation: elaborate NR `custom percussion’ section This patch adds a substantial amount of information to NR 2.5.1.6 "Custom percussion staves", with examples inspired by LSR #1033 and index entries for previously undocumented variables and properties. Accordingly, that snippet is no longer relevant in the snippets list (it has been untagged as `docs’ in the LSR and should therefore not be brought back by next makelsr update).

Patch Set 1 #

Total comments: 3

Created: 4 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+119 lines, -159 lines)			Patch
M	Documentation/notation/percussion.itely	View	3 chunks	+119 lines, -4 lines	3 comments	Download
D	Documentation/snippets/customize-drumpitchnames,-drumstyletable-and-drumpitchtable-in-layout-and-midi.ly	View	1 chunk	+0 lines, -151 lines	0 comments	Download
M	Documentation/snippets/midi.snippet-list	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Documentation/snippets/percussion.snippet-list	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Documentation/snippets/pitches.snippet-list	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Documentation/snippets/specific-notation.snippet-list	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lemzwerg

LGTM, thanks! https://codereview.appspot.com/550650043/diff/548760043/Documentation/notation/percussion.itely File Documentation/notation/percussion.itely (right): https://codereview.appspot.com/550650043/diff/548760043/Documentation/notation/percussion.itely#newcode423 Documentation/notation/percussion.itely:423: @code{drumStyleTable} property may then be set to ...

4 years, 11 months ago (2019-04-26 17:13:12 UTC) #1

Valentin Villenave

4 years, 11 months ago (2019-05-14 05:30:14 UTC) #2

On 2019/04/26 17:13:12, lemzwerg wrote:
> LGTM, thanks!

Thanks Werner, pushed as
https://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=bc46cc1fef7eecd0a64...

> I think this sentence should end with `... be set to', dropping the word
`use'.

I’m not sure what the LilyPond doc guidelines are with regard to dangling
prepositions :-)
I’ve turned it into "… to which the property may be set".

Thanks again!

V.

Expand All Messages | Collapse All Messages