Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(773)

Issue 5505097: Add the ability to iterate through a path without modification. This change is (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by Stephen Chenney
Modified:
12 years, 8 months ago
Reviewers:
caryclark1, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add the ability to iterate through a path without modification. This change is required by WebKit SVG in order to correctly draw markers and endcaps. BUG=415 TEST=TestPath in the unit tests Committed: http://code.google.com/p/skia/source/detail?r=2962

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+461 lines, -76 lines) Patch
M gm/degeneratesegments.cpp View 1 2 chunks +48 lines, -48 lines 0 comments Download
M include/core/SkPath.h View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
M src/core/SkPath.cpp View 1 2 3 chunks +77 lines, -2 lines 0 comments Download
M tests/PathTest.cpp View 1 4 chunks +311 lines, -26 lines 0 comments Download

Messages

Total messages: 5
reed1
Don't close this until SkPath::addPath has been modified. Right now it uses the default SkPath::Iter, ...
12 years, 8 months ago (2012-01-03 20:50:49 UTC) #1
Stephen Chenney
We're in good shape w.r.t. JS return values. They all make use of an intermediate ...
12 years, 8 months ago (2012-01-04 18:26:51 UTC) #2
Stephen Chenney
I hope we can get this in soon, as now I'm ready (finally) to move ...
12 years, 8 months ago (2012-01-04 20:05:38 UTC) #3
reed1
If we don't have an immediate caller for dumpRaw(), perhaps we can skip that (I'd ...
12 years, 8 months ago (2012-01-04 20:42:49 UTC) #4
Stephen Chenney
12 years, 8 months ago (2012-01-04 21:05:40 UTC) #5
I've removed the dumpRaw. Committing now. Thanks for the rapid attention.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b