Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(1232)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
5504116
: Fix off-by-one assertion error, improve coverage_to_exact_alpha (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by
TomH
Modified:
12 years, 10 months ago
Reviewers:
reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.
Description
We talked about converting coverage->alpha as 64 * coverage, but (256 >> SCALE) * coverage should be resilient to changes in SCALE.
Patch Set 1
#
Created:
12 years, 10 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+4 lines, -4 lines
)
Patch
M
src/core/SkBlitter.cpp
View
1 chunk
+1 line, -1 line
0 comments
Download
M
src/core/SkScan_AntiPath.cpp
View
1 chunk
+3 lines, -3 lines
0 comments
Download
Messages
Total messages: 3
Expand All Messages
|
Collapse All Messages
TomH
12 years, 10 months ago (2012-01-03 19:56:06 UTC)
#1
Sign in
to reply to this message.
reed1
LGTM
12 years, 10 months ago (2012-01-03 20:09:42 UTC)
#2
LGTM
Sign in
to reply to this message.
TomH
Closed in r2947.
12 years, 10 months ago (2012-01-03 20:13:01 UTC)
#3
Closed in r2947.
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 5504116: Fix off-by-one assertion error, improve coverage_to_exact_alpha (Closed)
Created 12 years, 10 months ago by TomH
Modified 12 years, 10 months ago
Reviewers: reed1
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b