Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(731)

Issue 5504107: T2026: Use new (scm markup-facility-defs) scheme module for markup commands. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by Ian Hulin (gmail)
Modified:
11 years, 4 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

T2026: Use new (scm markup-facility-defs) scheme module for markup commands. This affects the following files. New file scm/markup-utility-defs.scm ly/music-functions-init.ly Add (scm markup-facility-defs) to the #(use-modules (...) list. ly/titling-init.ly Add #(use-modules (scm markup-facility-defs)) statement. scm/chord-ignatzek-names Add (use-modules (scm markup-facility-defs)) statement. scm/define-event-classes.scm Change (define* simplify e) to (define simplify e) scm/define-markup-commands.scm Add (use-modules (scm markup-facility-defs)) statement. scm/define-woodwind-diagrams.scm Add (use-modules (scm markup-facility-defs)) statement. scm/display-lily.scm Add complete set of clauses to (define-module statement, and consolidate all statements into one file. scm/display-woodwind-diagrams.scm Add (use-modules (scm markup-facility-defs)) statement. scm/font.scm Add (use-modules (oops goops)) statement. scm/framework-ps.scm Add #:use-module (scm markup-facility-defs) clause to (define-module) statement. scm/fret-diagrams.scm Add (use-modules (scm markup-facility-defs)) statement. scm/harp-pedals.scm Add (use-modules (scm markup-facility-defs)) statement. scm/lily.scm Add (use-modules (scm markup-facility-defs)) statement. Group I18n declarations together at the beginning. Add some comments. Add better --loglevel=DEBUG statement when running with Guile V2. Add handling for conditions thrown in new markup-facility-defs module scm/markup.scm Gutted. scm/markup-macros.scm (will be deleted) scm/output-ps.scm Add :#duplicates (replace) clause to prevent squawks from (use-modules (guile)) statement. scm/tablature.scm Add (use-modules (scm markup-facility-defs)) statement. Regression tests: input/regression/markup-cyclic-references.ly Add #(use-modules (scm markup-facility-defs)) statement, using markup internal procedure outside of exported macro defs.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4302 lines, -2444 lines) Patch
M ly/music-functions-init.ly View 1 chunk +4 lines, -1 line 0 comments Download
M ly/titling-init.ly View 1 chunk +6 lines, -1 line 0 comments Download
M scm/chord-ignatzek-names.scm View 1 chunk +1 line, -1 line 0 comments Download
M scm/define-event-classes.scm View 2 chunks +3 lines, -2 lines 0 comments Download
M scm/define-markup-commands.scm View 7 chunks +2334 lines, -2277 lines 0 comments Download
M scm/define-woodwind-diagrams.scm View 3 chunks +13 lines, -11 lines 0 comments Download
M scm/display-lily.scm View 3 chunks +1176 lines, -3 lines 0 comments Download
M scm/display-woodwind-diagrams.scm View 1 chunk +1 line, -0 lines 0 comments Download
M scm/font.scm View 1 chunk +1 line, -1 line 0 comments Download
M scm/framework-ps.scm View 1 chunk +3 lines, -1 line 0 comments Download
M scm/fret-diagrams.scm View 1 chunk +1 line, -1 line 0 comments Download
M scm/harp-pedals.scm View 1 chunk +1 line, -1 line 0 comments Download
M scm/lily.scm View 12 chunks +106 lines, -20 lines 0 comments Download
M scm/markup.scm View 1 chunk +3 lines, -121 lines 0 comments Download
A scm/markup-facility-defs.scm View 1 chunk +643 lines, -0 lines 0 comments Download
M scm/output-ps.scm View 1 chunk +2 lines, -1 line 0 comments Download
M scm/page.scm View 1 chunk +3 lines, -1 line 0 comments Download
M scm/tablature.scm View 1 chunk +1 line, -1 line 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b