Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1603)

Issue 5504100: Doc: NR added @knownissue for beam properties (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by pkx166h
Modified:
12 years, 1 month ago
Reviewers:
Keith, Graham Percival, dak, carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: NR added @knownissue for beam properties Used Carl S's wording from comment #3 of Tracker 1566 Also collated to separate @warnings together as they looked odd in the doc as two separate 'note' boxes one after the other.

Patch Set 1 #

Total comments: 10

Patch Set 2 : 2nd Draft - thanks Keith/Carl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M Documentation/notation/rhythms.itely View 1 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 12
Carl
LGTM. I have some recommendations, but I won't hold up approval for them. Just for ...
12 years, 3 months ago (2012-01-01 01:55:11 UTC) #1
Keith
LGTM http://codereview.appspot.com/5504100/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/5504100/diff/1/Documentation/notation/rhythms.itely#newcode1903 Documentation/notation/rhythms.itely:1903: @code{@bs{}autoBeamOff} can produce unintended results. See the "can ...
12 years, 3 months ago (2012-01-01 02:59:06 UTC) #2
Carl
http://codereview.appspot.com/5504100/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/5504100/diff/1/Documentation/notation/rhythms.itely#newcode1954 Documentation/notation/rhythms.itely:1954: The properties of a beam are determined at the ...
12 years, 3 months ago (2012-01-01 03:08:19 UTC) #3
pkx166h
On 2012/01/01 03:08:19, Carl wrote: > http://codereview.appspot.com/5504100/diff/1/Documentation/notation/rhythms.itely > File Documentation/notation/rhythms.itely (right): > > http://codereview.appspot.com/5504100/diff/1/Documentation/notation/rhythms.itely#newcode1954 > ...
12 years, 3 months ago (2012-01-01 11:34:34 UTC) #4
Carl
> Can we show this using a single voice with non-chorded notes and by using ...
12 years, 3 months ago (2012-01-01 14:56:25 UTC) #5
dak
On 2012/01/01 14:56:25, Carl wrote: > > Can we show this using a single voice ...
12 years, 3 months ago (2012-01-01 15:06:05 UTC) #6
Keith
On 2012/01/01 15:06:05, dak wrote: > On 2012/01/01 14:56:25, Carl wrote: > > > Can ...
12 years, 2 months ago (2012-01-01 21:31:50 UTC) #7
pkx166h
On 2012/01/01 21:31:50, Keith wrote: > On 2012/01/01 15:06:05, dak wrote: > > On 2012/01/01 ...
12 years, 2 months ago (2012-01-01 22:33:15 UTC) #8
pkx166h
See comments below, thanks. http://codereview.appspot.com/5504100/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/5504100/diff/1/Documentation/notation/rhythms.itely#newcode1953 Documentation/notation/rhythms.itely:1953: @knownissues On 2012/01/01 01:55:11, Carl ...
12 years, 2 months ago (2012-01-01 22:33:33 UTC) #9
Keith
On Sun, 01 Jan 2012 14:33:33 -0800, <pkx166h@gmail.com> wrote: > I disagree. > > The ...
12 years, 2 months ago (2012-01-01 23:38:37 UTC) #10
Graham Percival
LGTM
12 years, 2 months ago (2012-01-30 12:10:35 UTC) #11
pkx166h
12 years, 1 month ago (2012-02-01 20:27:58 UTC) #12
committer	James Lowe <pkx166h@gmail.com>	

	 Wed, 1 Feb 2012 20:27:11 +0000 (20:27 +0000)

commit	d9d8de32b213adfcaf4ff318d79c2872e470578d
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b