Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1189)

Issue 5504090: Add SkDEBUGFAIL to clean up use of SkASSERT(!"text"); catch a couple of latent SkASSERT bugs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by TomH
Modified:
12 years, 9 months ago
Reviewers:
epoger
CC:
thakis
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Alternate solution to codereview.appspot.com/5328043/. There were a couple of apparent latent bugs where we'd forgotten the !: SkFontHost_mac_coretext.cpp and SkFontHost_FreeType.cpp. There were also a few places where we were already using SkASSERT(false && "text"); I changed those to SkDEBUGFAIL for consistency's sake.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -123 lines) Patch
M include/core/SkScalar.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkTypes.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/core/SkAAClip.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkBitmap.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M src/core/SkBitmapSampler.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/core/SkBlitter.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkBlitter_Sprite.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/core/SkColorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkConfig8888.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkDraw.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkEdgeBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkEdgeClipper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkFloat.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkMemory_stdlib.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkPaint.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkPath.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M src/core/SkPathMeasure.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRegion.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkScalerContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkScan_AntiPath.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkScan_Path.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M src/core/SkShader.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/Sk1DPathEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkBlurMask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkGradientShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkTransparentShader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/images/SkMovie_gif.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pipe/SkGPipeRead.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/ports/SkFontHost_android.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_fontconfig.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/ports/SkFontHost_freetype_mac.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/ports/SkFontHost_linux.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_mac_atsui.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ports/SkFontHost_mac_coretext.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M src/ports/SkFontHost_none.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M src/ports/SkFontHost_simple.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ports/SkMemory_brew.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ports/SkMemory_malloc.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ports/SkThread_pthread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/views/SkEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/views/SkWidgetViews.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/xml/SkBML_XMLParser.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
TomH
12 years, 9 months ago (2011-12-27 22:35:01 UTC) #1
epoger
LGTM
12 years, 9 months ago (2011-12-28 14:45:43 UTC) #2
TomH
12 years, 9 months ago (2011-12-28 15:11:07 UTC) #3
Closed with r2926.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b