Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2981)

Issue 5504055: Give slurs skylines in outside-staff-priority calculations. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by MikeSol
Modified:
12 years, 2 months ago
Reviewers:
mike, janek, dak, carl.d.sorensen, Neil Puttock, c_sorensen, wl, Keith
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Give slurs skylines in outside-staff-priority calculations.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorporates Neil's comments. #

Patch Set 3 : Implements Carl's suggestions. #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -0 lines) Patch
A input/regression/slur-vertical-skylines.ly View 1 chunk +16 lines, -0 lines 0 comments Download
M lily/general-scheme.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M lily/include/lily-guile.hh View 1 1 chunk +1 line, -0 lines 0 comments Download
M lily/include/slur.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/lily-guile.cc View 1 1 chunk +12 lines, -0 lines 2 comments Download
M lily/slur.cc View 1 2 3 chunks +26 lines, -0 lines 0 comments Download
M scm/define-grob-properties.scm View 1 1 chunk +2 lines, -0 lines 2 comments Download
M scm/define-grobs.scm View 2 chunks +2 lines, -0 lines 0 comments Download
M scm/lily.scm View 1 1 chunk +1 line, -0 lines 0 comments Download
M scm/safe-lily.scm View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16
Neil Puttock
http://codereview.appspot.com/5504055/diff/1/lily/slur.cc File lily/slur.cc (right): http://codereview.appspot.com/5504055/diff/1/lily/slur.cc#newcode388 lily/slur.cc:388: vsize N_BOXES = 100; Don't you think this is ...
12 years, 3 months ago (2011-12-21 15:59:52 UTC) #1
dak
http://codereview.appspot.com/5504055/diff/1/lily/slur.cc File lily/slur.cc (right): http://codereview.appspot.com/5504055/diff/1/lily/slur.cc#newcode388 lily/slur.cc:388: vsize N_BOXES = 100; On 2011/12/21 15:59:52, Neil Puttock ...
12 years, 3 months ago (2011-12-21 16:13:13 UTC) #2
Carl
On 2011/12/21 16:13:13, dak wrote: > http://codereview.appspot.com/5504055/diff/1/lily/slur.cc > File lily/slur.cc (right): > > http://codereview.appspot.com/5504055/diff/1/lily/slur.cc#newcode388 > ...
12 years, 3 months ago (2011-12-21 17:11:20 UTC) #3
mike_apollinemike.com
On Dec 21, 2011, at 6:11 PM, Carl.D.Sorensen@gmail.com wrote: > Mike, have you done any ...
12 years, 3 months ago (2011-12-21 19:44:22 UTC) #4
janek
Hi Mike, (i've come back finally) When i was thinking about LilyPond lately, i decided ...
12 years, 3 months ago (2011-12-25 21:50:42 UTC) #5
mike_apollinemike.com
On Dec 25, 2011, at 10:50 PM, Janek Warchoł wrote: > Hi Mike, > > ...
12 years, 3 months ago (2011-12-28 10:40:34 UTC) #6
wl_gnu.org
> I am not sure that dynamics and lyrics have subtleties in their shape that ...
12 years, 3 months ago (2011-12-28 10:49:59 UTC) #7
mike_apollinemike.com
On Dec 28, 2011, at 11:49 AM, Werner LEMBERG wrote: > >> I am not ...
12 years, 3 months ago (2011-12-28 11:30:01 UTC) #8
c_sorensen
On Dec 28, 2011, at 3:41 AM, "mike@apollinemike.com" <mike@apollinemike.com> wrote: > > On Dec 25, ...
12 years, 3 months ago (2011-12-28 12:01:56 UTC) #9
Neil Puttock
http://codereview.appspot.com/5504055/diff/3002/scm/define-grob-properties.scm File scm/define-grob-properties.scm (right): http://codereview.appspot.com/5504055/diff/3002/scm/define-grob-properties.scm#newcode1101 scm/define-grob-properties.scm:1101: (skyline-quantizing ,ly:vsize? "The number of boxes to break a ...
12 years, 3 months ago (2011-12-28 17:30:19 UTC) #10
mike_apollinemike.com
On Dec 28, 2011, at 6:30 PM, n.puttock@gmail.com wrote: > > http://codereview.appspot.com/5504055/diff/3002/scm/define-grob-properties.scm > File scm/define-grob-properties.scm ...
12 years, 3 months ago (2011-12-28 17:41:03 UTC) #11
Neil Puttock
On 2011/12/28 17:41:03, mike_apollinemike.com wrote: > I added it precisely to un-silently prevent negative numbers. ...
12 years, 3 months ago (2011-12-28 17:47:41 UTC) #12
mike_apollinemike.com
On Dec 28, 2011, at 6:47 PM, n.puttock@gmail.com wrote: > On 2011/12/28 17:41:03, mike_apollinemike.com wrote: ...
12 years, 3 months ago (2011-12-28 19:02:19 UTC) #13
mike_apollinemike.com
On Dec 28, 2011, at 8:02 PM, mike@apollinemike.com wrote: > On Dec 28, 2011, at ...
12 years, 3 months ago (2011-12-28 19:08:24 UTC) #14
Keith
http://codereview.appspot.com/5504055/diff/3002/lily/lily-guile.cc File lily/lily-guile.cc (right): http://codereview.appspot.com/5504055/diff/3002/lily/lily-guile.cc#newcode574 lily/lily-guile.cc:574: if (o >= 0) gcc gives a warning that ...
12 years, 3 months ago (2011-12-30 04:34:35 UTC) #15
Carl
12 years, 3 months ago (2011-12-30 04:56:50 UTC) #16
http://codereview.appspot.com/5504055/diff/3002/lily/lily-guile.cc
File lily/lily-guile.cc (right):

http://codereview.appspot.com/5504055/diff/3002/lily/lily-guile.cc#newcode573
lily/lily-guile.cc:573: o = scm_to_int (k);
shouldn't it be
  int i = scm_to_int (k)
   if  (i >= 0)
     return (vsize) i
  return o
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b