Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3961)

Issue 5503093: explain how to add git-cl to PATH (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by janek
Modified:
12 years, 3 months ago
Reviewers:
Graham Percival, pkx166h, dak, carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

explain how to add git-cl to PATH i know modifying PATH is basic knowledge, but i'm windows man and figuring this out took me 15 minutes... too long.

Patch Set 1 #

Total comments: 2

Patch Set 2 : extracting example #

Total comments: 3

Patch Set 3 : james' suggestions #

Patch Set 4 : test, sorry #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M Documentation/contributor/source-code.itexi View 1 2 3 1 chunk +12 lines, -4 lines 1 comment Download

Messages

Total messages: 13
janek
12 years, 3 months ago (2012-01-03 21:48:59 UTC) #1
Carl
I hesitate to do this because is it OS-specific. I think if we are going ...
12 years, 3 months ago (2012-01-03 21:55:09 UTC) #2
Graham Percival
Most linux distributions use bash, so this isn't a terrible idea. But you need to ...
12 years, 3 months ago (2012-01-03 22:05:58 UTC) #3
janek
second draft http://codereview.appspot.com/5503093/diff/4001/Documentation/contributor/source-code.itexi File Documentation/contributor/source-code.itexi (right): http://codereview.appspot.com/5503093/diff/4001/Documentation/contributor/source-code.itexi#newcode921 Documentation/contributor/source-code.itexi:921: @example should all this be in a ...
12 years, 3 months ago (2012-01-05 01:08:01 UTC) #4
pkx166h
http://codereview.appspot.com/5503093/diff/4001/Documentation/contributor/source-code.itexi File Documentation/contributor/source-code.itexi (right): http://codereview.appspot.com/5503093/diff/4001/Documentation/contributor/source-code.itexi#newcode921 Documentation/contributor/source-code.itexi:921: @example On 2012/01/05 01:08:01, janek wrote: > should all ...
12 years, 3 months ago (2012-01-05 06:05:23 UTC) #5
janek
third draft. http://codereview.appspot.com/5503093/diff/4001/Documentation/contributor/source-code.itexi File Documentation/contributor/source-code.itexi (right): http://codereview.appspot.com/5503093/diff/4001/Documentation/contributor/source-code.itexi#newcode921 Documentation/contributor/source-code.itexi:921: @example On 2012/01/05 06:05:23, J_lowe wrote: > ...
12 years, 3 months ago (2012-01-06 10:15:47 UTC) #6
pkx166h
On 2012/01/06 10:15:47, janek wrote: > third draft. > > http://codereview.appspot.com/5503093/diff/4001/Documentation/contributor/source-code.itexi > File Documentation/contributor/source-code.itexi (right): ...
12 years, 3 months ago (2012-01-06 11:07:29 UTC) #7
janek
On 2012/01/06 11:07:29, J_lowe wrote: > Sorry, an English Idiom. > "lift this section" = ...
12 years, 3 months ago (2012-01-06 11:45:03 UTC) #8
Graham Percival
LGTM
12 years, 3 months ago (2012-01-09 05:02:56 UTC) #9
janek
pushed to staging and closed.
12 years, 3 months ago (2012-01-11 04:42:47 UTC) #10
Graham Percival
this fails to compile. Removed from staging.
12 years, 3 months ago (2012-01-11 05:44:16 UTC) #11
dak
http://codereview.appspot.com/5503093/diff/4003/Documentation/contributor/source-code.itexi File Documentation/contributor/source-code.itexi (right): http://codereview.appspot.com/5503093/diff/4003/Documentation/contributor/source-code.itexi#newcode926 Documentation/contributor/source-code.itexi:926: PATH=~/type-here-directory-containing-git-cl:"${PATH}" $@{PATH@}
12 years, 3 months ago (2012-01-11 07:32:45 UTC) #12
janek
12 years, 3 months ago (2012-01-15 23:00:49 UTC) #13
Necessary @'s were added, patch was pushed as
67f64c0bdf4cd469de73b135df5ba61cbfea15f7
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b