Issue 5503080: Fix problems with SampleApp Fuzzer due to issues in iterating over degenerate paths.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5503080: Fix problems with SampleApp Fuzzer due to issues in iterating over degenerate paths. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by Stephen Chenney

Modified:
12 years, 11 months ago

Reviewers:
reed1, TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix problems with SampleApp Fuzzer due to issues in iterating over degenerate paths. The fuzzer gets my vote as best test tool ever. There are several issues outstanding: crashes in FixedPoint and a crash in the path filling code that is most likely due to clipping problems (but maybe not). BUG=425 Committed: http://code.google.com/p/skia/source/detail?r=2936

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
	M	include/core/SkPath.h	View		1 chunk	+8 lines, -2 lines	0 comments	Download
	M	src/core/SkPath.cpp	View	1	3 chunks	+3 lines, -9 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

After a bit of brain-stretching LGTM.

Expand All Messages | Collapse All Messages