Issue 5503068: Series of commits directed to solve once and for all this issue

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5503068: Series of commits directed to solve once and for all this issue

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by Carlos Córdoba

Modified:
13 years, 2 months ago

Reviewers:
pierre.raybaut, techtonik, Carlos Córdoba

Visibility:
Public.

More Reviews

Description

Issue 812

Patch Set 1 #

Total comments: 1

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -25 lines)			Patch
M	spyderlib/plugins/editor.py	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	spyderlib/plugins/history.py	View	2 chunks	+6 lines, -1 line	1 comment	Download
M	spyderlib/spyder.py	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	spyderlib/userconfig.py	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	spyderlib/utils/encoding.py	View	2 chunks	+24 lines, -3 lines	0 comments	Download
M	spyderlib/utils/external/path.py	View	2 chunks	+2 lines, -8 lines	0 comments	Download
M	spyderlib/utils/module_completion.py	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	spyderlib/widgets/sourcecode/codeeditor.py	View	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

pierre.raybaut

13 years, 2 months ago (2012-01-07 14:37:46 UTC) #1

http://codereview.appspot.com/5503068/diff/1/spyderlib/plugins/history.py
File spyderlib/plugins/history.py (right):

http://codereview.appspot.com/5503068/diff/1/spyderlib/plugins/history.py#new...
spyderlib/plugins/history.py:243: if os.environ.get('QT_API') != 'pyside':
This is not a good idea: this won't work with PyQt API #2 for which filename
won't be a QString.

The simplest way for dealing with this would be:
(this is doing exactly the same thing as your original code but will work with
PyQt API#1/2 and PySide)

if not isinstance(filename, basestring): # filename is a QString
    filename = unicode(filename.toUtf8(), 'utf-8')
command = unicode(command)

Expand All Messages | Collapse All Messages