Issue 5503058: Refine Makefile and do not install engine.db if English mode is disabled.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5503058: Refine Makefile and do not install engine.db if English mode is disabled. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by Peng

Modified:
12 years, 3 months ago

Reviewers:
Peng Wu, Yusuke Sato

Base URL:
git@github.com:ibus/ibus-pinyin.git@master

Visibility:
Public.

More Reviews

Description

Refine Makefile and do not install engine.db if English mode is disabled. Move english related files into data/db/english folder and update Makefile.am BUG=None TEST=make & make install

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix review issues #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -20060 lines)			Patch
M	configure.ac	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	data/Makefile.am	View		1 chunk	+0 lines, -24 lines	0 comments	Download
M	data/db/Makefile.am	View		2 chunks	+15 lines, -2 lines	0 comments	Download
M	data/db/android/Makefile.am	View		1 chunk	+0 lines, -2 lines	0 comments	Download
A +	data/db/english/Makefile.am	View		1 chunk	+0 lines, -5 lines	0 comments	Download
A +	data/db/english/english.awk	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	data/db/english/wordlist	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	data/db/open-phrase/Makefile.am	View		2 chunks	+0 lines, -3 lines	0 comments	Download
D	data/english.awk	View		1 chunk	+0 lines, -25 lines	0 comments	Download
	data/wordlist	View		1 chunk	+0 lines, -20000 lines	0 comments	Download
M	src/PYEnglishEditor.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Peng Wu

Please also update the english.db path in src/PYEnglishEditor.cc. gboolean result = m_english_database->openDatabase (".." G_DIR_SEPARATOR_S "data" ...

12 years, 3 months ago (2011-12-26 03:38:31 UTC) #2

Peng

Fixed in https://github.com/phuang/ibus-pinyin/commit/3a1d3f5e8210f29c9de7c5c1bbf51228fccaa9cd Please review it. On 2011/12/26 03:38:31, Peng Wu wrote: > Please also ...

12 years, 3 months ago (2011-12-27 04:52:44 UTC) #3

lgtm

Expand All Messages | Collapse All Messages