remove one un-needed static initializer

remove one un-needed static initializer
    
This patch removes the use of a static C++ object in the
implementation of SkMatrix44::isIdentity(). Instead, we rely
on direct comparison with a statically allocated array of
SkMScalar values, which is completely equivalent.
Committed: http://code.google.com/p/skia/source/detail?r=2991

[caryclark1, 2011-12-22 17:08:12]

lgtm

[reed1, 2011-12-22 17:25:59]

not sure that works in fixed-point, lets test first.

[digit, 2011-12-22 17:27:23]

On Thu, Dec 22, 2011 at 6:26 PM, <reed@google.com> wrote:

> not sure that works in fixed-point, lets test first.
>
>
http://codereview.appspot.com/**5502067/<http://codereview.appspot.com/5502067/>
>

I could do that, is there a way to run with fixed points on Linux?

[digit, 2011-12-22 17:33:50]

Looking at the source code, it looks like SkMscalar is always defined as either
float or double. I don't think the change should introduce any change in
behaviour even if the rest of the library uses fixed-point. Let me know
otherwise.

[reed1, 2011-12-22 18:01:25]

doh, I thought this was SkMatrix, not SkMatrix44. You're right, there is no
fixed involved.

Not sure why you use 1. and 0. instead of 1 and 0

lgtm

[digit, 2012-01-09 21:52:38]

On 2011/12/22 18:01:25, reed1 wrote:
> doh, I thought this was SkMatrix, not SkMatrix44. You're right, there is no
> fixed involved.
> 
> Not sure why you use 1. and 0. instead of 1 and 0
> 
The 1. and 0. is a habit, I'll change them to 1 and 0 for the sake of
consistency.

(the point of using dotted numbers like that is to make it explicit that the
values are floating points, and not integers. This sometimes help catch
mistakes).

> lgtm