Issue 5500066: Make all fields of IBusProperty as gobject property.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5500066: Make all fields of IBusProperty as gobject property. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by Peng

Modified:
12 years, 4 months ago

Reviewers:
fujiwara

CC:
Yusuke Sato

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Make all fields of IBusProperty as gobject property. BUG=http://code.google.com/p/ibus/issues/detail?id=1383 TEST=Linux desktop

Patch Set 1 #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+376 lines, -136 lines)			Patch
	M	src/ibusproperty.h	View		6 chunks	+16 lines, -25 lines	0 comments	Download
	M	src/ibusproperty.c	View		16 chunks	+360 lines, -111 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fujiwara

On 2011/12/21 22:01:04, Peng wrote: lgtm BTW, it's also no problem to delete ibus_property_get_* methods ...

12 years, 4 months ago (2011-12-22 10:13:48 UTC) #2

Peng

12 years, 4 months ago (2011-12-22 14:57:37 UTC) #3

On 2011/12/22 10:13:48, fujiwara wrote:
> On 2011/12/21 22:01:04, Peng wrote:
> 
> lgtm
> 
> BTW, it's also no problem to delete ibus_property_get_* methods since gjs also
> can access the GObject properties.
>
https://github.com/ibus/ibus/commit/37e6e58792bef4284653e4d8f4c93c901780eafd#...

I see. But C language can not get those properties easily. :)

Expand All Messages | Collapse All Messages