Issue 5500044: asColorMatrix() extractor for SkColorMatrixFilter, gm

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5500044: asColorMatrix() extractor for SkColorMatrixFilter, gm (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by Stephen White

Modified:
12 years, 6 months ago

Reviewers:
reed, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Implement SkColorFilter::asColorMatrix() virtual, and override in SkColorMatrixFilter. Implement missing SkColorMatrixFilter::setMatrix() and setArray() functions (were in .h, just not implemented). Add a gm for color matrix filters.

Patch Set 1 #

Patch Set 2 : Fix comment #

Total comments: 2

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+141 lines, -0 lines)			Patch
gm/colormatrix.cpp	View		1 chunk	+104 lines, -0 lines	0 comments	Download
gyp/gmslides.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
include/core/SkColorFilter.h	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
include/effects/SkColorMatrixFilter.h	View		1 chunk	+1 line, -0 lines	2 comments	Download
src/core/SkColorFilter.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download
src/effects/SkColorMatrixFilter.cpp	View		1 chunk	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

reed1

lgtm w/ SK_OVERRIDE addition http://codereview.appspot.com/5500044/diff/8/include/effects/SkColorMatrixFilter.h File include/effects/SkColorMatrixFilter.h (right): http://codereview.appspot.com/5500044/diff/8/include/effects/SkColorMatrixFilter.h#newcode29 include/effects/SkColorMatrixFilter.h:29: virtual bool asColorMatrix(SkScalar matrix[20]); SK_OVERRIDE

12 years, 6 months ago (2011-12-20 20:45:04 UTC) #4

Stephen White

http://codereview.appspot.com/5500044/diff/8/include/effects/SkColorMatrixFilter.h File include/effects/SkColorMatrixFilter.h (right): http://codereview.appspot.com/5500044/diff/8/include/effects/SkColorMatrixFilter.h#newcode29 include/effects/SkColorMatrixFilter.h:29: virtual bool asColorMatrix(SkScalar matrix[20]); On 2011/12/20 20:45:05, reed1 wrote: ...

12 years, 6 months ago (2011-12-20 20:52:55 UTC) #5

Landed as r2909; closing.

Expand All Messages | Collapse All Messages