Issue 5498107: Patches NSIS

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5498107: Patches NSIS (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by MikeSol

Modified:
13 years, 2 months ago

Reviewers:
Keith, mail

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Patches NSIS

Patch Set 1 #

Total comments: 1

Patch Set 2 : Second stab at fixing NSIS #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	gub/specs/nsis.py	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Keith

Overall, I think it wiser to avoid touching the windows path, *but* this concept has ...

13 years, 3 months ago (2012-01-04 19:00:39 UTC) #1

mail_philholmes.net

13 years, 3 months ago (2012-01-04 19:40:12 UTC) #2

----- Original Message ----- 
From: <k-ohara5a5a@oco.net>
To: <mtsolo@gmail.com>
Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org>
Sent: Wednesday, January 04, 2012 7:00 PM
Subject: Patches NSIS (issue 5498107)

> Overall, I think it wiser to avoid touching the windows path, *but* this
> concept has been reported to resolve the problem.
>
> http://nsis.sourceforge.net/Special_Builds
> If you can run GUB, can you try putting the changed parameter on the
> scons command line, rather than patching the default parameters.
> Changes in the upstream nsis could easily cause the patch no not apply.
>
>
> http://codereview.appspot.com/5498107/diff/1/gub/specs/nsis.py
> File gub/specs/nsis.py (right):
>
> http://codereview.appspot.com/5498107/diff/1/gub/specs/nsis.py#newcode14
> gub/specs/nsis.py:14: scons_flags = misc.join_lines ('''
> NSIS_MAX_STRLEN=8192
>
> http://codereview.appspot.com/5498107/

I think this is highly likely to be the problem.  Yesterday I tried putting 
long strings into Windows registry, and got to over 70k characters before I 
got bored. I concluded that it wasn't a problem with the length of strings 
in the registry and therefore less likely to be a "feature" of windows PATH. 
I assume that what happens is the path gets close to the NSIS string size 
limit, is read, appended to, and thus truncated, and is then written back to 
the registry.

If someone with GUB capability can create a test patch, I'd be happy to try 
it out (tho' not tomorrow - working).

--
Phil Holmes

Expand All Messages | Collapse All Messages