Issue 5498052: Coverity: Add a default case in SkPDFShader.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5498052: Coverity: Add a default case in SkPDFShader. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by thestig

Modified:
12 years, 7 months ago

Reviewers:
Steve VanDeBogart

CC:
skia-review_googlegroups.com, groby

Base URL:
http://skia.googlecode.com/svn/trunk/src/

Visibility:
Public.

More Reviews

Description

Coverity: Add a default case in SkPDFShader. CID=101159 BUG=none TEST=none

Patch Set 2 : '' #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	pdf/SkPDFShader.cpp	View	1	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Steve VanDeBogart

LGTM with comment. http://codereview.appspot.com/5498052/diff/1/pdf/SkPDFShader.cpp File pdf/SkPDFShader.cpp (right): http://codereview.appspot.com/5498052/diff/1/pdf/SkPDFShader.cpp#newcode461 pdf/SkPDFShader.cpp:461: SkASSERT(codeFunction); I think this is deadcode ...

12 years, 9 months ago (2011-12-20 21:40:12 UTC) #2

thestig

http://codereview.appspot.com/5498052/diff/1/pdf/SkPDFShader.cpp File pdf/SkPDFShader.cpp (right): http://codereview.appspot.com/5498052/diff/1/pdf/SkPDFShader.cpp#newcode461 pdf/SkPDFShader.cpp:461: SkASSERT(codeFunction); On 2011/12/20 21:40:13, Steve VanDeBogart wrote: > I ...

12 years, 9 months ago (2011-12-20 21:47:14 UTC) #3

landed as r2913

Expand All Messages | Collapse All Messages