Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1358)

Issue 549780045: Refactor \markup \pattern

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 12 months ago by dak
Modified:
3 years, 12 months ago
Reviewers:
幹你娘, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Refactor \markup \pattern

Patch Set 1 #

Total comments: 5

Patch Set 2 : Explain different spacing for vertical patterns #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -21 lines) Patch
M scm/define-markup-commands.scm View 1 3 chunks +7 lines, -21 lines 0 comments Download

Messages

Total messages: 9
hanwenn
https://codereview.appspot.com/549780045/diff/555530045/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/549780045/diff/555530045/scm/define-markup-commands.scm#newcode4636 scm/define-markup-commands.scm:4636: (space (if (= axis X) space (* 3.0 space)))) ...
3 years, 12 months ago (2020-03-31 20:22:35 UTC) #1
dak
https://codereview.appspot.com/549780045/diff/555530045/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/549780045/diff/555530045/scm/define-markup-commands.scm#newcode4636 scm/define-markup-commands.scm:4636: (space (if (= axis X) space (* 3.0 space)))) ...
3 years, 12 months ago (2020-03-31 22:17:02 UTC) #2
dak
Explain different spacing for vertical patterns
3 years, 12 months ago (2020-03-31 22:33:14 UTC) #3
hanwenn
https://codereview.appspot.com/549780045/diff/555530045/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/549780045/diff/555530045/scm/define-markup-commands.scm#newcode4675 scm/define-markup-commands.scm:4675: (count (inexact->exact (truncate (/ (- middle-width pattern-width) period)))) On ...
3 years, 12 months ago (2020-04-01 06:55:07 UTC) #4
幹你娘
幹你娘 5:07, hanwenn wrote: > https://codereview.appspot.com/549780045/diff/555530045/scm/define-markup-commands.scm<font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > 文件scm / define-markup-commands.scm(右):</font></font><font></font> > ...
3 years, 12 months ago (2020-04-01 17:53:56 UTC) #5
幹你娘
你去死 17:02, dak wrote: > https://codereview.appspot.com/549780045/diff/555530045/scm/define-markup-commands.scm<font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > 文件scm / define-markup-commands.scm(右):</font></font><font></font> > ...
3 years, 12 months ago (2020-04-01 17:56:46 UTC) #6
幹你娘
On 2020/04/01 17:56:46, 周 wrote: > <font style="vertical-align: inherit;"><font style="vertical-align: inherit;">你去死</font></font><font></font> > <font></font> > <font></font> ...
3 years, 12 months ago (2020-04-01 17:59:00 UTC) #7
幹你娘
On 2020/04/01 17:56:46, 周 wrote: > <font style="vertical-align: inherit;"><font style="vertical-align: inherit;">你去死</font></font><font></font> > <font></font> > <font></font> ...
3 years, 12 months ago (2020-04-01 17:59:01 UTC) #8
幹你娘
3 years, 12 months ago (2020-04-01 18:00:15 UTC) #9
幹你娘
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b