Issue 5496077: Added -fstack-protector-strong option to gcc.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5496077: Added -fstack-protector-strong option to gcc. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by asharif1

Modified:
13 years, 3 months ago

Reviewers:
shenhan, Diego Novillo, jingyu, bjanakiraman

CC:
gcc-patches_gcc.gnu.org

Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Broke long line. #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+240 lines, -3 lines)			Patch
M	gcc-4_6-mobile/gcc/ChangeLog.google-4_6	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	gcc-4_6-mobile/gcc/cfgexpand.c	View		3 chunks	+53 lines, -3 lines	0 comments	Download
M	gcc-4_6-mobile/gcc/common.opt	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	gcc-4_6-mobile/gcc/testsuite/ChangeLog.google-4_6	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	gcc-4_6-mobile/gcc/testsuite/g++.dg/fstack-protector-strong.C	View		1 chunk	+35 lines, -0 lines	0 comments	Download
A	gcc-4_6-mobile/gcc/testsuite/gcc.dg/fstack-protector-strong.c	View		1 chunk	+135 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

shenhan

13 years, 4 months ago (2011-12-20 00:30:02 UTC) #2

LGTM

On Mon, Dec 19, 2011 at 4:01 PM, <asharif@google.com> wrote:

> Reviewers: Diego Novillo, shenhan, jingyu, bjanakiraman_google.com,
>
> Message:
> Please review this on behalf of shenhan@.
>
>
>
> Please review this at
http://codereview.appspot.com/**5496077/<http://codereview.appspot.com/5496077/>
>
> Affected files:
>  M     gcc-4_6-mobile/gcc/ChangeLog.**google-4_6
>  M     gcc-4_6-mobile/gcc/cfgexpand.c
>  M     gcc-4_6-mobile/gcc/common.opt
>  M     gcc-4_6-mobile/gcc/testsuite/**ChangeLog.google-4_6
>  A     gcc-4_6-mobile/gcc/testsuite/**g++.dg/fstack-protector-**strong.C
>  A     gcc-4_6-mobile/gcc/testsuite/**gcc.dg/fstack-protector-**strong.c
>
>
>


-- 
 Han Shen |  Software Engineer |  shenhan@google.com |  +1-650-440-3330

Expand All Messages | Collapse All Messages