Issue 5496066: code review 5496066: vim: fix go filetype detection

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5496066: code review 5496066: vim: fix go filetype detection

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by tones111

Modified:
12 years, 4 months ago

Reviewers:
dsymonds

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

vim: fix go filetype detection The filetype needs to be set during BufRead in order for the did_filetype() check to prevent the file being detected as a conf file. One example where this can occur is if a cgo file has a #include at the top of the file. The # is detected in vim's generic configuration (conf file) toward the bottom of filetype.vim

Patch Set 1 #

Patch Set 2 : diff -r 0c39eee85b0d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 15b63cc10b22 https://go.googlecode.com/hg/ #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	misc/vim/ftdetect/gofiletype.vim	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

tones111

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 4 months ago (2011-12-18 23:16:59 UTC) #1

dsymonds

12 years, 4 months ago (2011-12-18 23:43:00 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=fe3bea7c6c36 ***

vim: fix go filetype detection

The filetype needs to be set during BufRead in order for the did_filetype()
check to prevent the file being detected as a conf file.  One example where this
can occur is if a cgo file has a #include at the top of the file.  The # is
detected in vim's generic configuration (conf file) toward the bottom of
filetype.vim

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/5496066

Committer: David Symonds <dsymonds@golang.org>

Expand All Messages | Collapse All Messages