Adding py sample for google analytics core reporting api

Fixed here: http://code.google.com/p/google-api-python-client/source/detail?r=63c6ac00f393ea3596b275953a5f47dd67c1bdc2

closing this

[jcgregorio_google, 2012-01-06 18:52:00]

http://codereview.appspot.com/5494058/diff/4/samples/analytics/core_reporting...
File samples/analytics/core_reporting_v3_reference.py (right):

http://codereview.appspot.com/5494058/diff/4/samples/analytics/core_reporting...
samples/analytics/core_reporting_v3_reference.py:70: FLOW = OAuth2WebServerFlow(
Please update the sample to use client_secrets.json.

See
http://code.google.com/p/google-api-python-client/source/browse/samples/plus/...

Also update management_v3_reference.py in the same way.

http://codereview.appspot.com/5494058/diff/4/samples/analytics/core_reporting...
samples/analytics/core_reporting_v3_reference.py:144: class View(object):
This is a class that carries no state. Delete the class and just use functions.

http://codereview.appspot.com/5494058/diff/4/samples/analytics/core_reporting...
samples/analytics/core_reporting_v3_reference.py:163: """Prints general
information about this report."""
Document the parameters. Same for all functions.

[jcgregorio_google, 2012-03-06 15:01:59]

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/hello_anal...
File samples/analytics/hello_analytics_api_v3.py (right):

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/hello_anal...
samples/analytics/hello_analytics_api_v3.py:164: if results.get('rows'):
if 'rows' in results:

or combine these two lines into:

for row in results.get('rows', []):

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/management...
File samples/analytics/management_v3_reference.py (right):

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/management...
samples/analytics/management_v3_reference.py:49: $ python analytics.py
name is wrong

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/management...
samples/analytics/management_v3_reference.py:174: for webproperty in
webproperties_response.get('items'):
.get('items', []):

would be safer because then the loop would just be skipped if 'items' is
missing, as opposed to raising a TypeError, which is what would happen now.

Here and throughout.

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/management...
samples/analytics/management_v3_reference.py:175: print 'Kind               =
%s' % webproperty.get('kind')
Have you considered string templates instead of the huge raft of prints?

  http://docs.python.org/library/string.html#template-strings

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/management...
samples/analytics/management_v3_reference.py:309: for goal_step in
goal_details.get('steps'):
for goal_step in goal_details.get('steps', []):

and you can drop the if.

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/sample_uti...
File samples/analytics/sample_utils.py (right):

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/sample_uti...
samples/analytics/sample_utils.py:90: """Uses the command-line flags to set the
logging level."""
document parameter

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/sample_uti...
samples/analytics/sample_utils.py:103: def prepare_credentials():
Seems gratuitous to break out prepare_credentials and retrieve_service as
separate functions given how little they do and that only initialize_service is
called from outside this file. Either collapse into initialize_service or mark
them as private and document their parameters.

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/sample_uti...
samples/analytics/sample_utils.py:124: """Builds instance of service from
discovery data and does auth."""
document return value

[nm, 2012-03-06 19:05:44]

fixed them.

On Tue, Mar 6, 2012 at 7:01 AM, <jcgregorio@google.com> wrote:

>
> http://codereview.appspot.com/**5494058/diff/10001/samples/**
>
analytics/hello_analytics_api_**v3.py<http://codereview.appspot.com/5494058/diff/10001/samples/analytics/hello_analytics_api_v3.py>
> File samples/analytics/hello_**analytics_api_v3.py (right):
>
> http://codereview.appspot.com/**5494058/diff/10001/samples/**
>
analytics/hello_analytics_api_**v3.py#newcode164<http://codereview.appspot.com/5494058/diff/10001/samples/analytics/hello_analytics_api_v3.py#newcode164>
> samples/analytics/hello_**analytics_api_v3.py:164: if results.get('rows'):
> if 'rows' in results:
>
> or combine these two lines into:
>
> for row in results.get('rows', []):
>
> http://codereview.appspot.com/**5494058/diff/10001/samples/**
>
analytics/management_v3_**reference.py<http://codereview.appspot.com/5494058/diff/10001/samples/analytics/management_v3_reference.py>
> File samples/analytics/management_**v3_reference.py (right):
>
> http://codereview.appspot.com/**5494058/diff/10001/samples/**
>
analytics/management_v3_**reference.py#newcode49<http://codereview.appspot.com/5494058/diff/10001/samples/analytics/management_v3_reference.py#newcode49>
> samples/analytics/management_**v3_reference.py:49: $ python analytics.py
> name is wrong
>
> http://codereview.appspot.com/**5494058/diff/10001/samples/**
>
analytics/management_v3_**reference.py#newcode174<http://codereview.appspot.com/5494058/diff/10001/samples/analytics/management_v3_reference.py#newcode174>
> samples/analytics/management_**v3_reference.py:174: for webproperty in
> webproperties_response.get('**items'):
> .get('items', []):
>
> would be safer because then the loop would just be skipped if 'items' is
> missing, as opposed to raising a TypeError, which is what would happen
> now.
>
> Here and throughout.
>
> http://codereview.appspot.com/**5494058/diff/10001/samples/**
>
analytics/management_v3_**reference.py#newcode175<http://codereview.appspot.com/5494058/diff/10001/samples/analytics/management_v3_reference.py#newcode175>
> samples/analytics/management_**v3_reference.py:175: print 'Kind
>   = %s' % webproperty.get('kind')
> Have you considered string templates instead of the huge raft of prints?
>
> 
http://docs.python.org/**library/string.html#template-**strings<http://docs.p...
>
> http://codereview.appspot.com/**5494058/diff/10001/samples/**
>
analytics/management_v3_**reference.py#newcode309<http://codereview.appspot.com/5494058/diff/10001/samples/analytics/management_v3_reference.py#newcode309>
> samples/analytics/management_**v3_reference.py:309: for goal_step in
> goal_details.get('steps'):
> for goal_step in goal_details.get('steps', []):
>
> and you can drop the if.
>
> http://codereview.appspot.com/**5494058/diff/10001/samples/**
>
analytics/sample_utils.py<http://codereview.appspot.com/5494058/diff/10001/samples/analytics/sample_utils.py>
> File samples/analytics/sample_**utils.py (right):
>
> http://codereview.appspot.com/**5494058/diff/10001/samples/**
>
analytics/sample_utils.py#**newcode90<http://codereview.appspot.com/5494058/diff/10001/samples/analytics/sample_utils.py#newcode90>
> samples/analytics/sample_**utils.py:90: """Uses the command-line flags to
> set the logging level."""
> document parameter
>
> http://codereview.appspot.com/**5494058/diff/10001/samples/**
>
analytics/sample_utils.py#**newcode103<http://codereview.appspot.com/5494058/diff/10001/samples/analytics/sample_utils.py#newcode103>
> samples/analytics/sample_**utils.py:103: def prepare_credentials():
> Seems gratuitous to break out prepare_credentials and retrieve_service
> as separate functions given how little they do and that only
> initialize_service is called from outside this file. Either collapse
> into initialize_service or mark them as private and document their
> parameters.
>
> http://codereview.appspot.com/**5494058/diff/10001/samples/**
>
analytics/sample_utils.py#**newcode124<http://codereview.appspot.com/5494058/diff/10001/samples/analytics/sample_utils.py#newcode124>
> samples/analytics/sample_**utils.py:124: """Builds instance of service
> from discovery data and does auth."""
> document return value
>
>
http://codereview.appspot.com/**5494058/<http://codereview.appspot.com/5494058/>
>

[jsoneja, 2012-03-06 22:33:55]

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/hello_anal...
File samples/analytics/hello_analytics_api_v3.py (right):

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/hello_anal...
samples/analytics/hello_analytics_api_v3.py:22: authorized users first profile
ID. Then the sample uses this ID to
users's

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/hello_anal...
samples/analytics/hello_analytics_api_v3.py:29: The register the project to use
OAuth2.0 for installed applications.
s/The/Then/

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/hello_anal...
samples/analytics/hello_analytics_api_v3.py:32: into the client_secrest.json
file that is in the same directory as this sample.
client_secrets.json

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/hello_anal...
samples/analytics/hello_analytics_api_v3.py:41: $ python
hello_analytics_api_v3.py --help
if we do decide to rename the java sample, we should rename this accordingly.

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/management...
File samples/analytics/management_v3_reference.py (right):

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/management...
samples/analytics/management_v3_reference.py:54: $ python analytics.py --help
here too .. update the name

[nm, 2012-03-07 23:33:02]

all done.

On Tue, Mar 6, 2012 at 2:33 PM, <jsoneja@google.com> wrote:

>
> http://codereview.appspot.com/**5494058/diff/10001/samples/**
>
analytics/hello_analytics_api_**v3.py<http://codereview.appspot.com/5494058/diff/10001/samples/analytics/hello_analytics_api_v3.py>
> File samples/analytics/hello_**analytics_api_v3.py (right):
>
> http://codereview.appspot.com/**5494058/diff/10001/samples/**
>
analytics/hello_analytics_api_**v3.py#newcode22<http://codereview.appspot.com/5494058/diff/10001/samples/analytics/hello_analytics_api_v3.py#newcode22>
> samples/analytics/hello_**analytics_api_v3.py:22: authorized users first
> profile ID. Then the sample uses this ID to
> users's
>
> http://codereview.appspot.com/**5494058/diff/10001/samples/**
>
analytics/hello_analytics_api_**v3.py#newcode29<http://codereview.appspot.com/5494058/diff/10001/samples/analytics/hello_analytics_api_v3.py#newcode29>
> samples/analytics/hello_**analytics_api_v3.py:29: The register the project
> to use OAuth2.0 for installed applications.
> s/The/Then/
>
> http://codereview.appspot.com/**5494058/diff/10001/samples/**
>
analytics/hello_analytics_api_**v3.py#newcode32<http://codereview.appspot.com/5494058/diff/10001/samples/analytics/hello_analytics_api_v3.py#newcode32>
> samples/analytics/hello_**analytics_api_v3.py:32: into the
> client_secrest.json file that is in the same directory as this sample.
> client_secrets.json
>
> http://codereview.appspot.com/**5494058/diff/10001/samples/**
>
analytics/hello_analytics_api_**v3.py#newcode41<http://codereview.appspot.com/5494058/diff/10001/samples/analytics/hello_analytics_api_v3.py#newcode41>
> samples/analytics/hello_**analytics_api_v3.py:41: $ python
> hello_analytics_api_v3.py --help
> if we do decide to rename the java sample, we should rename this
> accordingly.
>
>
> http://codereview.appspot.com/**5494058/diff/10001/samples/**
>
analytics/management_v3_**reference.py<http://codereview.appspot.com/5494058/diff/10001/samples/analytics/management_v3_reference.py>
> File samples/analytics/management_**v3_reference.py (right):
>
> http://codereview.appspot.com/**5494058/diff/10001/samples/**
>
analytics/management_v3_**reference.py#newcode54<http://codereview.appspot.com/5494058/diff/10001/samples/analytics/management_v3_reference.py#newcode54>
> samples/analytics/management_**v3_reference.py:54: $ python analytics.py
> --help
> here too .. update the name
>
>
http://codereview.appspot.com/**5494058/<http://codereview.appspot.com/5494058/>
>

[jsoneja, 2012-03-07 23:41:47]

LGTM

[jcgregorio_google, 2012-03-08 18:49:16]

On 2012/03/07 23:41:47, jsoneja wrote:
> LGTM

LGTM

Be sure to follow the updated submit instructions:

 
http://code.google.com/p/google-api-python-client/wiki/BecomingAContributor#S...

[api.nickm1, 2012-03-09 08:27:28]

Thanks. Can you add api.nickm@gmail.com as a committer to this project?

-Nick

On Thu, Mar 8, 2012 at 10:49 AM, <jcgregorio@google.com> wrote:

> On 2012/03/07 23:41:47, jsoneja wrote:
>
>> LGTM
>>
>
> LGTM
>
> Be sure to follow the updated submit instructions:
>
>
> http://code.google.com/p/**google-api-python-client/wiki/**
>
BecomingAContributor#**Submitting_Your_Approved_Code<http://code.google.com/p/google-api-python-client/wiki/BecomingAContributor#Submitting_Your_Approved_Code>
>
>
http://codereview.appspot.com/**5494058/<http://codereview.appspot.com/5494058/>
>

[api.nickm1, 2012-03-12 16:24:24]

Great updated here:
http://code.google.com/p/google-api-python-client/source/detail?r=63c6ac00f39...

Thanks


On 2012/03/09 08:27:28, api.nickm1 wrote:
> Thanks. Can you add mailto:api.nickm@gmail.com as a committer to this project?
> 
> -Nick
> 
> On Thu, Mar 8, 2012 at 10:49 AM, <mailto:jcgregorio@google.com> wrote:
> 
> > On 2012/03/07 23:41:47, jsoneja wrote:
> >
> >> LGTM
> >>
> >
> > LGTM
> >
> > Be sure to follow the updated submit instructions:
> >
> >
> > http://code.google.com/p/**google-api-python-client/wiki/**
> >
>
BecomingAContributor#**Submitting_Your_Approved_Code<http://code.google.com/p/google-api-python-client/wiki/BecomingAContributor#Submitting_Your_Approved_Code>
> >
> >
>
http://codereview.appspot.com/**5494058/%3Chttp://codereview.appspot.com/5494...>
> >

[api.nickm1, 2012-04-26 06:30:15]

http://codereview.appspot.com/5494058/diff/4/samples/analytics/core_reporting...
File samples/analytics/core_reporting_v3_reference.py (right):

http://codereview.appspot.com/5494058/diff/4/samples/analytics/core_reporting...
samples/analytics/core_reporting_v3_reference.py:70: FLOW = OAuth2WebServerFlow(
On 2012/01/06 18:52:00, jcgregorio_google wrote:
> Please update the sample to use client_secrets.json.
> 
> See
>
http://code.google.com/p/google-api-python-client/source/browse/samples/plus/...
> 
> Also update management_v3_reference.py in the same way.

Done.

http://codereview.appspot.com/5494058/diff/4/samples/analytics/core_reporting...
samples/analytics/core_reporting_v3_reference.py:144: class View(object):
On 2012/01/06 18:52:00, jcgregorio_google wrote:
> This is a class that carries no state. Delete the class and just use
functions.

Done.

http://codereview.appspot.com/5494058/diff/4/samples/analytics/core_reporting...
samples/analytics/core_reporting_v3_reference.py:163: """Prints general
information about this report."""
On 2012/01/06 18:52:00, jcgregorio_google wrote:
> Document the parameters. Same for all functions.

Done.

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/hello_anal...
File samples/analytics/hello_analytics_api_v3.py (right):

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/hello_anal...
samples/analytics/hello_analytics_api_v3.py:22: authorized users first profile
ID. Then the sample uses this ID to
On 2012/03/06 22:33:55, jsoneja wrote:
> users's

Done.

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/hello_anal...
samples/analytics/hello_analytics_api_v3.py:29: The register the project to use
OAuth2.0 for installed applications.
On 2012/03/06 22:33:55, jsoneja wrote:
> s/The/Then/

Done.

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/hello_anal...
samples/analytics/hello_analytics_api_v3.py:32: into the client_secrest.json
file that is in the same directory as this sample.
On 2012/03/06 22:33:55, jsoneja wrote:
> client_secrets.json

Done.

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/hello_anal...
samples/analytics/hello_analytics_api_v3.py:41: $ python
hello_analytics_api_v3.py --help
On 2012/03/06 22:33:55, jsoneja wrote:
> if we do decide to rename the java sample, we should rename this accordingly.

lets do in another cl since renaming now is a bit tricky

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/hello_anal...
samples/analytics/hello_analytics_api_v3.py:164: if results.get('rows'):
On 2012/03/06 15:01:59, jcgregorio_google wrote:
> if 'rows' in results:
> 
> or combine these two lines into:
> 
> for row in results.get('rows', []):

Done.

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/management...
File samples/analytics/management_v3_reference.py (right):

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/management...
samples/analytics/management_v3_reference.py:49: $ python analytics.py
On 2012/03/06 15:01:59, jcgregorio_google wrote:
> name is wrong

Done.

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/management...
samples/analytics/management_v3_reference.py:54: $ python analytics.py --help
On 2012/03/06 22:33:55, jsoneja wrote:
> here too .. update the name

fixed in the previous patch

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/management...
samples/analytics/management_v3_reference.py:174: for webproperty in
webproperties_response.get('items'):
On 2012/03/06 15:01:59, jcgregorio_google wrote:
> .get('items', []):
> 
> would be safer because then the loop would just be skipped if 'items' is
> missing, as opposed to raising a TypeError, which is what would happen now.
> 
> Here and throughout.

Done.

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/management...
samples/analytics/management_v3_reference.py:175: print 'Kind               =
%s' % webproperty.get('kind')
we did in the past. For readability it seemed easier to look at the code since
everything was on the same line. Generally the use case for this file is just to
look up how to access our APIs data using this library. So while there are lots
of prints, it seems easier to read this way.

On 2012/03/06 15:01:59, jcgregorio_google wrote:
> Have you considered string templates instead of the huge raft of prints?
> 
>   http://docs.python.org/library/string.html#template-strings

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/management...
samples/analytics/management_v3_reference.py:309: for goal_step in
goal_details.get('steps'):
On 2012/03/06 15:01:59, jcgregorio_google wrote:
> for goal_step in goal_details.get('steps', []):
> 
> and you can drop the if.

Done.

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/sample_uti...
File samples/analytics/sample_utils.py (right):

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/sample_uti...
samples/analytics/sample_utils.py:90: """Uses the command-line flags to set the
logging level."""
On 2012/03/06 15:01:59, jcgregorio_google wrote:
> document parameter

Done.

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/sample_uti...
samples/analytics/sample_utils.py:103: def prepare_credentials():
I decided to remove them.

On 2012/03/06 15:01:59, jcgregorio_google wrote:
> Seems gratuitous to break out prepare_credentials and retrieve_service as
> separate functions given how little they do and that only initialize_service
is
> called from outside this file. Either collapse into initialize_service or mark
> them as private and document their parameters.

http://codereview.appspot.com/5494058/diff/10001/samples/analytics/sample_uti...
samples/analytics/sample_utils.py:124: """Builds instance of service from
discovery data and does auth."""
On 2012/03/06 15:01:59, jcgregorio_google wrote:
> document return value

Done.