Issue 549320043: Fix regtests about Footnote

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 549320043: Fix regtests about Footnote (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 4 months ago by thomasmorley651

Modified:
4 years ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Issue 5640 Fix regtests about Footnote Several regtest about FootnoteItem/Spanner contained overrides without specifying the context. Footnote_engraver lives in Score-context, since Issue 1773. Probably an oversight. Thus the Score-context is added to the overrides in: input/regression/footnote-auto-numbering.ly input/regression/footnote-spanner.ly input/regression/in-note.ly Regtest-diffs are expected. input/regression/footnote-auto-numbering-vertical-order.ly is broken as well. This will need some more thoughts, beyond the scope of this patch.

Patch Set 1 #

Patch Set 2 : removing footnote-auto-numbering-vertical-order.ly #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	input/regression/footnote-auto-numbering.ly	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	input/regression/footnote-spanner.ly	View	1 chunk	+1 line, -1 line	0 comments	Download
M	input/regression/in-note.ly	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

thomasmorley651

removing footnote-auto-numbering-vertical-order.ly

4 years, 4 months ago (2019-12-15 15:24:12 UTC) #2

thomasmorley651

4 years, 4 months ago (2019-12-15 15:28:35 UTC) #3

patch-description is changed.
Fixing footnote-auto-numbering-vertical-order.ly will take more work than simply
correct context-settings

Expand All Messages | Collapse All Messages