code is fine, but I'm not sure I could regenerate those tables http://codereview.appspot.com/5493049/diff/1/src/gpu/GrDrawTarget.cpp File src/gpu/GrDrawTarget.cpp ...
12 years, 11 months ago
(2011-12-15 15:50:11 UTC)
#3
On 2011/12/15 15:50:11, reed1 wrote: > code is fine, but I'm not sure I could ...
12 years, 11 months ago
(2011-12-15 16:59:01 UTC)
#4
On 2011/12/15 15:50:11, reed1 wrote:
> code is fine, but I'm not sure I could regenerate those tables
>
> http://codereview.appspot.com/5493049/diff/1/src/gpu/GrDrawTarget.cpp
> File src/gpu/GrDrawTarget.cpp (right):
>
>
http://codereview.appspot.com/5493049/diff/1/src/gpu/GrDrawTarget.cpp#newcode46
> src/gpu/GrDrawTarget.cpp:46: /* These values were generated by the above
> function */
> can you show exactly how one would call gen_mask_arrays to re-generate these
> values? e.g.
>
> #if 0
> static void rebuild_stage_arrays() {
> ...
> gen_mask_arrays(...);
> for ...
> printf("gStageTexCoordMasks[] = { %d %d %d ...);
> }
Done. I added a function that prints the decl/init code.
Closed with r2898
Issue 5493049: Compile time vertex layout masks
(Closed)
Created 12 years, 11 months ago by bsalomon
Modified 12 years, 11 months ago
Reviewers: reed1, TomH
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 1