Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(179)

Issue 5493049: Compile time vertex layout masks (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by bsalomon
Modified:
12 years, 11 months ago
Reviewers:
TomH, reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -46 lines) Patch
M src/gpu/GrDrawTarget.cpp View 11 chunks +69 lines, -46 lines 1 comment Download

Messages

Total messages: 4
bsalomon
This is me waiving a white flag.
12 years, 11 months ago (2011-12-15 15:05:41 UTC) #1
TomH
LGTM
12 years, 11 months ago (2011-12-15 15:13:27 UTC) #2
reed1
code is fine, but I'm not sure I could regenerate those tables http://codereview.appspot.com/5493049/diff/1/src/gpu/GrDrawTarget.cpp File src/gpu/GrDrawTarget.cpp ...
12 years, 11 months ago (2011-12-15 15:50:11 UTC) #3
bsalomon
12 years, 11 months ago (2011-12-15 16:59:01 UTC) #4
On 2011/12/15 15:50:11, reed1 wrote:
> code is fine, but I'm not sure I could regenerate those tables
> 
> http://codereview.appspot.com/5493049/diff/1/src/gpu/GrDrawTarget.cpp
> File src/gpu/GrDrawTarget.cpp (right):
> 
>
http://codereview.appspot.com/5493049/diff/1/src/gpu/GrDrawTarget.cpp#newcode46
> src/gpu/GrDrawTarget.cpp:46: /* These values were generated by the above
> function */
> can you show exactly how one would call gen_mask_arrays to re-generate these
> values? e.g.
> 
> #if 0
> static void rebuild_stage_arrays() {
>     ...
>      gen_mask_arrays(...);
>      for ...
>         printf("gStageTexCoordMasks[] = { %d %d %d ...);
> }

Done. I added a function that prints the decl/init code.

Closed with r2898
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b