Issue 549270043: Replace string exceptions by RuntimeError

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 549270043: Replace string exceptions by RuntimeError (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 4 months ago by hahnjo

Modified:
4 years, 3 months ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Replace string exceptions by RuntimeError Apparently string exceptions have already been removed in Python 2.6: https://docs.python.org/2/whatsnew/2.6.html#deprecations-and-removals As such, I don't think these code paths are taken very often...

Patch Set 1 #

Patch Set 2 : Replace additional string exceptions #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
M	python/convertrules.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	python/musicexp.py	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	python/musicxml.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	scripts/auxiliar/update-snippets.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Replace additional string exceptions

Expand All Messages | Collapse All Messages