Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(658)

Issue 549220043: Issue 5622: simplify Spanner pure property cache (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by Dan Eble
Modified:
4 years, 3 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5622/ 1. int->vsize in Spanner This change will avoid new type-conversion warnings when similar changes are made in other places in the future. It does not on its own reduce the number of warnings. 2. simplify Spanner pure property cache * move construction of key into a function * call scm_cons2 instead of calling scm_cons twice * simplify testing whether the cache has been initialized

Patch Set 1 : int->vsize in Spanner #

Patch Set 2 : simplify Spanner pure property cache #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -13 lines) Patch
M lily/include/spanner.hh View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/spanner.cc View 1 1 chunk +19 lines, -11 lines 0 comments Download

Messages

Total messages: 3
Dan Eble
simplify Spanner pure property cache
4 years, 4 months ago (2019-11-27 01:39:27 UTC) #1
Dan Eble
4 years, 4 months ago (2019-11-27 01:40:48 UTC) #2
lemzwerg
4 years, 4 months ago (2019-11-27 07:43:45 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b