Issue 5491078: Merged r182417 from branches/google/gcc-4_6.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5491078: Merged r182417 from branches/google/gcc-4_6. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by asharif1

Modified:
13 years, 2 months ago

Reviewers:
xur, jingyu, bjanakiraman, shenhan

CC:
gcc-patches_gcc.gnu.org

Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/

Visibility:
Public.

Patch Set 1 #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -0 lines)			Patch
M	gcc-4_6-mobile	View	0 chunks	+0 lines, -0 lines	0 comments	Download
M	gcc-4_6-mobile/gcc/ChangeLog.google-4_6	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	gcc-4_6-mobile/gcc/libgcov.c	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

asharif1

This merges xur's patch to our mobile release branch. LGTM and I will submit it.

13 years, 3 months ago (2011-12-19 22:09:18 UTC) #1

jingyu

On 2011/12/19 22:09:18, asharif1 wrote: > This merges xur's patch to our mobile release branch. ...

13 years, 3 months ago (2011-12-19 22:43:31 UTC) #2

shenhan

LGTM++ -Han On Mon, Dec 19, 2011 at 2:43 PM, <jingyu@google.com> wrote: > On 2011/12/19 ...

13 years, 3 months ago (2011-12-19 23:00:31 UTC) #3

xur

13 years, 3 months ago (2011-12-19 23:50:21 UTC) #4

LGTM

On Mon, Dec 19, 2011 at 3:00 PM, Han Shen(沈涵) <shenhan@google.com> wrote:

> LGTM++
>
> -Han
>
>
> On Mon, Dec 19, 2011 at 2:43 PM, <jingyu@google.com> wrote:
>
>> On 2011/12/19 22:09:18, asharif1 wrote:
>>
>>> This merges xur's patch to our mobile release branch. LGTM and I will
>>>
>> submit it.
>>
>> OK
>>
>>
http://codereview.appspot.com/**5491078/<http://codereview.appspot.com/5491078/>
>>
>
>
>
> --
>  Han Shen |  Software Engineer |  shenhan@google.com |  +1-650-440-3330
>

Expand All Messages | Collapse All Messages