Issue 5490066: Implements FormatEpochTimeInMillisAsIso8601 on WIndows CE

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5490066: Implements FormatEpochTimeInMillisAsIso8601 on WIndows CE

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by Vlad

Modified:
11 years, 2 months ago

Reviewers:
kevin2

Base URL:
http://googletest.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Removes commented pragmas. #

Patch Set 3 : Reformats the code and moves variable declaration closer to its use. #

Patch Set 4 : Splits FormatEpochTimeInMillisAsIso8601Test for Windows Mobile and the rest. #

Patch Set 5 : Removes _tmain from gtest_unittest.cc #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -30 lines)			Patch
M	src/gtest.cc	View	1	2 chunks	+30 lines, -8 lines	0 comments	Download
M	src/gtest-internal-inl.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/gtest_main.cc	View	1 2 3 4	1 chunk	+5 lines, -1 line	0 comments	Download
M	test/gtest_unittest.cc	View	1 2 3 4	4 chunks	+45 lines, -21 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

kevin2

time_zone_info.(Bias|StandardBias|DaylightBias) = 0 lines can be deleted.

14 years, 1 month ago (2011-12-19 22:38:40 UTC) #1

kevin2

14 years, 1 month ago (2011-12-19 22:42:38 UTC) #2

GTEST_OS_WINDOWS_MOBILE version of FormatEpochTimeInMillisAsIso8601Test
needs

  static const TimeInMillis kMillisPerSec = 1000;	

as it's used in the test declarations later.

With this added it the tests pass on both Win7 and WinCE.  I'm not hitting the
permissions problems I hit earlier.  So that was a good call on your part if a
bit of a mystery to me.

Expand All Messages | Collapse All Messages