Issue 5489126: Fixed to return false in ibus_simple_engine_process_key_event

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5489126: Fixed to return false in ibus_simple_engine_process_key_event (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by fujiwara

Modified:
12 years, 4 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git://github.com/ibus/ibus-xkb.git@master

Visibility:
Public.

More Reviews

Description

Fixed to return false in ibus_simple_engine_process_key_event IM clients expect filter_keypress returns FALSE when IME is disabled. Now we use the simple engine instead of the disabled state so it would be better that process_key_event returns FALSE for ASCII. BUG=RH#769133 TEST=Linux desktop

Patch Set 1 #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	xkb/ibus-simple-engine.c	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

On 2011/12/29 17:41:05, fujiwara wrote:

lgtm

Expand All Messages | Collapse All Messages