Issue 5489123: Add number-of-missing-baseline-images report to gm

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5489123: Add number-of-missing-baseline-images report to gm (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by epoger

Modified:
12 years, 9 months ago

Reviewers:
TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add number-of-missing-baseline-images report to gm Committed: http://code.google.com/p/skia/source/detail?r=2929

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+145 lines, -115 lines)			Patch
	M	gm/gmmain.cpp	View	1 2	17 chunks	+145 lines, -115 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

TomH

LGTM. Nits: * You're tracking more types of errors than you're reporting? * Could we ...

12 years, 9 months ago (2011-12-28 19:13:47 UTC) #2

epoger

12 years, 9 months ago (2011-12-28 19:30:34 UTC) #3

On 2011/12/28 19:13:47, TomH wrote:
> LGTM.
> 
> Nits:
> * You're tracking more types of errors than you're reporting?
Added a comment about this.

> * Could we not list clauses (passed, failed, missing) if the numbers are 0? or
> are you thinking that the buildbot might parse this output, and that'd be
easier
> if we have consistent format?
Yeah, eventually we would like to automatically parse the output.  Even aside
from that, I find value in explicitly reporting what we looked for but did NOT
encounter.

> 
> Supernit: nouns are pluralized even if %d == 1
These 1 requests are ridiculous.

Expand All Messages | Collapse All Messages