Issue 5488048: Access sampler matrices directly, cleanup GrSamplerState::reset()s

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5488048: Access sampler matrices directly, cleanup GrSamplerState::reset()s (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by bsalomon

Modified:
13 years ago

Reviewers:
TomH

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : cleanup #

Total comments: 2

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -77 lines)			Patch
M	gm/texdata.cpp	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	include/gpu/GrSamplerState.h	View	1	5 chunks	+20 lines, -34 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View		3 chunks	+6 lines, -12 lines	0 comments	Download
M	src/gpu/GrDrawTarget.cpp	View		1 chunk	+1 line, -1 line	2 comments	Download
M	src/gpu/GrGpuGL.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrGpuGLShaders.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View		8 chunks	+20 lines, -26 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

TomH

LGTM http://codereview.appspot.com/5488048/diff/2001/src/gpu/GrDrawTarget.cpp File src/gpu/GrDrawTarget.cpp (right): http://codereview.appspot.com/5488048/diff/2001/src/gpu/GrDrawTarget.cpp#newcode1088 src/gpu/GrDrawTarget.cpp:1088: *drawState->sampler(s)->matrix() = fSamplerMatrices[s]; Is this better, or just ...

13 years ago (2011-12-12 18:36:40 UTC) #2

bsalomon

13 years ago (2011-12-12 18:45:33 UTC) #3

Checked in at r2854.

http://codereview.appspot.com/5488048/diff/2001/src/gpu/GrDrawTarget.cpp
File src/gpu/GrDrawTarget.cpp (right):

http://codereview.appspot.com/5488048/diff/2001/src/gpu/GrDrawTarget.cpp#newc...
src/gpu/GrDrawTarget.cpp:1088: *drawState->sampler(s)->matrix() =
fSamplerMatrices[s];
On 2011/12/12 18:36:40, TomH wrote:
> Is this better, or just the new style?
Just new style, I didn't want to leave the setter lest people use it
unnecessarily.

Expand All Messages | Collapse All Messages